Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Arrow keys wont work #51

Closed
Bizarrus opened this issue Nov 9, 2023 · 2 comments
Closed

[BUG] Arrow keys wont work #51

Bizarrus opened this issue Nov 9, 2023 · 2 comments
Assignees
@cpendery
Labels
bug Something isn't working
Milestone
November 2023

Comments

@Bizarrus
Copy link

Bizarrus commented Nov 9, 2023

Describe the bug
Arrow keys wont work

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Install 'npm install -g @microsoft/inshellisense'
  3. execute 'inshellisense bind'
  4. select bash
  5. Enter some commands
  6. use arrow up or arrow down
  7. Nothing happens

Expected behavior

 if (key.upArrow) {
    setSelectionIdx(Math.max(0, selectionIdx - 1));
}
else if (key.downArrow) {
    setSelectionIdx(Math.min(availableShells.length - 1, selectionIdx + 1));
}

Self-explanatory.I think setSelectionIdx will not executed, i dont know..

Environment

  • OS: Debian 12, Linux my.fruit 5.15.90.1-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 GNU/Linux
  • Output of inshellisense --version: 0.0.1-rc.4
  • Nodejs Version: node -v (v18.13.0), npm -v (9.2.0)
@Bizarrus Bizarrus added the bug Something isn't working label Nov 9, 2023
@cpendery
Copy link
Member

cpendery commented Nov 9, 2023

Duplicate of #9

@cpendery cpendery marked this as a duplicate of #9 Nov 9, 2023
@cpendery cpendery self-assigned this Nov 9, 2023
@cpendery cpendery added this to the November 2023 milestone Nov 9, 2023
@yixiaojiu yixiaojiu mentioned this issue Nov 10, 2023
Closed
@cpendery
Copy link
Member

cpendery commented Dec 5, 2023

Closing as this was fixed in 0.0.1-rc.5

@cpendery cpendery closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpendery cpendery

Labels
bug Something isn't working
Projects
None yet
Milestone
November 2023
Development

No branches or pull requests
2 participants
@Bizarrus @cpendery