chore: codestyle and roslyn analyzers best practices (#171)

Author: JamieMagee

.editorconfig

@@ -1,40 +1,33 @@
 <Project>
 
-    <PropertyGroup Label="Build">
-        <TargetFramework>netcoreapp3.1</TargetFramework>
-        <LangVersion>latest</LangVersion>
-        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-        <TreatWarningsAsErrors Condition="'$(OFFICIAL_BUILD)' == 'True'">true</TreatWarningsAsErrors>
-    </PropertyGroup>
+  <PropertyGroup Label="Build">
+    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <LangVersion>latest</LangVersion>
+    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    <AnalysisLevel>latest</AnalysisLevel>
+    <AnalysisMode>AllEnabledByDefault</AnalysisMode>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+    <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
+    <NoWarn>$(NoWarn);CS1591;NU1608,NU5119;SA1600</NoWarn>
+  </PropertyGroup>
 
-    <PropertyGroup Label="Package">
-        <Authors>Microsoft</Authors>
-        <Company>Microsoft</Company>
-        <Copyright>Copyright © Microsoft Corporation. All rights reserved.</Copyright>
-        <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-        <PackageLicenseExpression>MIT</PackageLicenseExpression>
-        <PackageProjectUrl>https://github.com/microsoft/component-detection</PackageProjectUrl>
-        <RepositoryUrl>https://github.com/microsoft/component-detection.git</RepositoryUrl>
-        <RepositoryType>git</RepositoryType>
-        <PackageReleaseNotes>https://github.com/microsoft/component-detection/releases</PackageReleaseNotes>
-    </PropertyGroup>
+  <PropertyGroup Label="Package">
+    <Authors>Microsoft</Authors>
+    <Company>Microsoft</Company>
+    <Copyright>Copyright © Microsoft Corporation. All rights reserved.</Copyright>
+    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
+    <PackageLicenseExpression>MIT</PackageLicenseExpression>
+    <PackageProjectUrl>https://github.com/microsoft/component-detection</PackageProjectUrl>
+    <RepositoryUrl>https://github.com/microsoft/component-detection.git</RepositoryUrl>
+    <RepositoryType>git</RepositoryType>
+    <PackageReleaseNotes>https://github.com/microsoft/component-detection/releases</PackageReleaseNotes>
+  </PropertyGroup>
 
-    <ItemGroup Label="Package References">
-        <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" PrivateAssets="all"/>
-        <PackageReference Include="MinVer" PrivateAssets="all"/>
-        <PackageReference Include="StyleCop.Analyzers" PrivateAssets="all"/>
-    </ItemGroup>
+  <ItemGroup Label="Package References">
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" PrivateAssets="all"/>
+    <PackageReference Include="MinVer" PrivateAssets="all"/>
+    <PackageReference Include="StyleCop.Analyzers" PrivateAssets="all"/>
+  </ItemGroup>
 
-    <PropertyGroup>
-        <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)analyzers.ruleset</CodeAnalysisRuleSet>
-        <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
-        <NoWarn>NU1608,NU5119</NoWarn>
-    </PropertyGroup>
-    <PropertyGroup Condition="'$(OFFICIAL_BUILD)'=='True'">
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    </PropertyGroup>
-
-    <ItemGroup Label="Package References">
-        <PackageReference Include="MinVer" PrivateAssets="all"/>
-    </ItemGroup>
 </Project>

Directory.Build.props

@@ -13,10 +13,10 @@
         <PackageVersion Include="Docker.DotNet" Version="3.125.5"/>
         <PackageVersion Include="FluentAssertions" Version="6.7.0"/>
         <PackageVersion Include="Microsoft.AspNet.WebApi.Client" Version="5.2.9"/>
-        <PackageVersion Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0"/>
         <PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="3.1.26" />
         <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.2.0"/>
         <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1"/>
+        <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.2.32"/>
         <PackageVersion Include="DotNet.Glob" Version="2.1.4"/>
         <PackageVersion Include="MinVer" Version="4.1.0"/>
         <PackageVersion Include="Moq" Version="4.18.1"/>
@@ -30,7 +30,7 @@
         <PackageVersion Include="packageurl-dotnet" Version="1.0.0"/>
         <PackageVersion Include="Polly" Version="7.2.3"/>
         <PackageVersion Include="Semver" Version="2.0.6"/>
-        <PackageVersion Include="StyleCop.Analyzers" Version="1.1.118"/>
+        <PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.435"/>
         <PackageVersion Include="System.Composition.AttributedModel" Version="1.4.1"/>
         <PackageVersion Include="System.Composition.Convention" Version="1.4.1"/>
         <PackageVersion Include="System.Composition.Hosting" Version="1.4.1"/>