Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [WCR] Requesting too large of a scaled image freezes app and leads to long wait time #183

Open
zateutsch opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
🐛bug Something isn't working wcr-api

Comments

@zateutsch
Copy link
Contributor

Noticed this when I was working with WCR before, but if you scale an image that's already large or with a larger scale factor, it will freeze out the app and take forever.

Possible solution:
make the scale slider relative to the uploaded image thats bound on the larger of the two dimensions of the image, and maintains the aspect ratio of the image when slid.

We could then max out resolution to something like 4000px for the larger of the dimensionalities, and the slider could go from [Original Image Size] => [Max Determined Output Size for Reasonable Performance]

If this just took a long time, I don't think it would be a problem, but the fact that it is freezing the app is bad. Maybe there's just a tasking fix to this as well so it can happen on the background.

@zateutsch zateutsch added wcr-api 🐛bug Something isn't working labels Feb 10, 2025
@zateutsch zateutsch self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working wcr-api
Projects
None yet
Development

No branches or pull requests

1 participant