locale0.cpp: Protect memory integrity of _Fac_node (#4916)

li-boxuan · CaseyCarter · web-flow · commit 3cf597e5f1c6 · 2024-08-27T21:25:17.000-07:00
Co-authored-by: Casey Carter &lt;cacarter@microsoft.com&gt;
diff --git a/stl/src/locale0.cpp b/stl/src/locale0.cpp
@@ -30,7 +30,6 @@ struct _Fac_node { // node for lazy facet recording
         delete _Facptr->_Decref();
     }
 
-#ifdef _DEBUG
     void* operator new(size_t _Size) { // replace operator new
         void* _Ptr = _malloc_dbg(_Size > 0 ? _Size : 1, _CRT_BLOCK, __FILE__, __LINE__);
         if (!_Ptr) {
@@ -43,7 +42,6 @@ struct _Fac_node { // node for lazy facet recording
     void operator delete(void* _Ptr) noexcept { // replace operator delete
         _free_dbg(_Ptr, _CRT_BLOCK);
     }
-#endif // defined(_DEBUG)
 
     _Fac_node* _Next;
     _Facet_base* _Facptr;

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ struct _Fac_node { // node for lazy facet recording`
`30`	`30`	`delete _Facptr->_Decref();`
`31`	`31`	`}`
`32`	`32`
`33`		`-#ifdef _DEBUG`
`34`	`33`	`void* operator new(size_t _Size) { // replace operator new`
`35`	`34`	`void* _Ptr = _malloc_dbg(_Size > 0 ? _Size : 1, _CRT_BLOCK, __FILE__, __LINE__);`
`36`	`35`	`if (!_Ptr) {`
`@@ -43,7 +42,6 @@ struct _Fac_node { // node for lazy facet recording`
`43`	`42`	`void operator delete(void* _Ptr) noexcept { // replace operator delete`
`44`	`43`	`_free_dbg(_Ptr, _CRT_BLOCK);`
`45`	`44`	`}`
`46`		`-#endif // defined(_DEBUG)`
`47`	`45`
`48`	`46`	`_Fac_node* _Next;`
`49`	`47`	`_Facet_base* _Facptr;`