<chrono>: Add comments for compiler bug workarounds (#4920)

frederick-vs-ja · StephanTLavavej · web-flow · commit 1acbeae8dfec · 2024-08-27T21:32:53.000-07:00
Co-authored-by: Stephan T. Lavavej &lt;stl@nuwen.net&gt;
diff --git a/stl/inc/chrono b/stl/inc/chrono
@@ -2209,6 +2209,7 @@ namespace chrono {
             auto [_Icu_version, _Zones, _Links] = _Tzdb_generate_time_zones();
             auto [_Leap_sec, _All_ls_positive]  = _Tzdb_generate_leap_seconds(0);
             auto _Version                       = _Icu_version + "." + _STD to_string(_Leap_sec.size());
+            // TRANSITION, VSO-2228186, should call emplace_front with construction arguments
             _Tzdb_list.emplace_front(tzdb{
                 _STD move(_Version), _STD move(_Zones), _STD move(_Links), _STD move(_Leap_sec), _All_ls_positive});
         }
@@ -2266,6 +2267,7 @@ namespace chrono {
                 }
 
                 auto _Version = _Tzdb_update_version(_Tzdb.version, _Leap_sec.size());
+                // TRANSITION, VSO-2228186, should call emplace_front with construction arguments
                 _Tzdb_list.emplace_front(tzdb{
                     _STD move(_Version), _STD move(_Zones), _STD move(_Links), _STD move(_Leap_sec), _All_ls_positive});
             }

Original file line number	Diff line number	Diff line change
`@@ -2209,6 +2209,7 @@ namespace chrono {`
`2209`	`2209`	`auto [_Icu_version, _Zones, _Links] = _Tzdb_generate_time_zones();`
`2210`	`2210`	`auto [_Leap_sec, _All_ls_positive] = _Tzdb_generate_leap_seconds(0);`
`2211`	`2211`	`auto _Version = _Icu_version + "." + _STD to_string(_Leap_sec.size());`
	`2212`	`+ // TRANSITION, VSO-2228186, should call emplace_front with construction arguments`
`2212`	`2213`	`_Tzdb_list.emplace_front(tzdb{`
`2213`	`2214`	`_STD move(_Version), _STD move(_Zones), _STD move(_Links), _STD move(_Leap_sec), _All_ls_positive});`
`2214`	`2215`	`}`
`@@ -2266,6 +2267,7 @@ namespace chrono {`
`2266`	`2267`	`}`
`2267`	`2268`
`2268`	`2269`	`auto _Version = _Tzdb_update_version(_Tzdb.version, _Leap_sec.size());`
	`2270`	`+ // TRANSITION, VSO-2228186, should call emplace_front with construction arguments`
`2269`	`2271`	`_Tzdb_list.emplace_front(tzdb{`
`2270`	`2272`	`_STD move(_Version), _STD move(_Zones), _STD move(_Links), _STD move(_Leap_sec), _All_ls_positive});`
`2271`	`2273`	`}`