From bd0685b8a0bee7d3a0bfe16cbddb38439d8d93b3 Mon Sep 17 00:00:00 2001 From: Wei Dai Date: Fri, 12 Feb 2021 14:01:19 -0800 Subject: [PATCH 1/2] Added an intruction in bench.cpp to run benchmarks for more repetitions. --- native/bench/bench.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/native/bench/bench.cpp b/native/bench/bench.cpp index d02fbe208..1530280cd 100644 --- a/native/bench/bench.cpp +++ b/native/bench/bench.cpp @@ -14,6 +14,8 @@ namespace sealbench { /** Wraps benchmark::RegisterBenchmark to use microsecond and accepts std::string name. + Each benchmark runs for 10 rather than a dynamically chosen amount of iterations. + If more runs are needed for more accurate measurements, either remove line 26, or run benchmarks in repetition. */ #define SEAL_BENCHMARK_REGISTER(category, n, log_q, name, func, ...) \ RegisterBenchmark( \ From 67669e893b4f037bafd218655b0488a732a4723d Mon Sep 17 00:00:00 2001 From: Wei Dai Date: Fri, 12 Feb 2021 14:33:04 -0800 Subject: [PATCH 2/2] Fixed missing zlib header files when SEAL_BUILD_DEPS and SEAL_BUILD_SHARED are both on. --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index a29ff42f7..1efceb8b2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -390,6 +390,8 @@ else() if(SEAL_USE_ZLIB) target_link_libraries(seal_shared PRIVATE ${zlib}) + target_include_directories(seal_shared PRIVATE $) + target_include_directories(seal_shared PRIVATE $>) endif() if(SEAL_USE_ZSTD)