Magnifier #94
Merged
Magnifier #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing magnification
Tried Experimenting with HLSL instead of CG based off the fullscreen ColorBlit example, still doesn't work in URP or single pass instance rendering
I've managed to perform a fullscreen blit in multi pass , got single pass instance working in the editor, but for some reason it doesn't work in playmode like multi pass
New progress on the magnifier test shader, with the center and magification amounts exposed as public variables for easy manipulation
scene update with XR interaction toolkit
… but not without issues currently trying to find an alternative to bliting for XR URP Grabpass for XR
new changes
|
Thank you for posting the draft! Would you be able to remove/clean up the files which don't need to be reviewed? For example, these files don't need to be checked in: There might be some things we need to add to our gitignore. 😅 |
Deleted some files that were not necessary for review
pinkwerks
reviewed
Oct 10, 2022
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenFeature.cs
Outdated
Show resolved
Hide resolved
pinkwerks
reviewed
Oct 10, 2022
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenPass.cs
Outdated
Show resolved
Hide resolved
|
I see there are Samples~, but they are not showing up in the Package Manager. You can add your entry here: |
|
In the sample scene.... seeing some stretching of the zoomed content when resizing the game window. Also some magenta shaders.... |
| @@ -3,7 +3,7 @@ | |||
| --- !u!30 &1 | |||
| GraphicsSettings: | |||
| m_ObjectHideFlags: 0 | |||
| serializedVersion: 14 | |||
| serializedVersion: 13 | |||
There was a problem hiding this comment.
I bet this entire file could be reverted since you likely didn't mean to change the render pipeline we point to be default?
com.microsoft.mrtk.graphicstools.unity/Runtime/Experimental/Magnifier/Materials.meta
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Experimental/Magnifier/Shaders/Magnifier.shader
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenFeature.cs
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenPass.cs
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenPass.cs
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenPass.cs
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenPass.cs
Show resolved
Hide resolved
...soft.mrtk.graphicstools.unity/Samples~/Experimental/Magnifier/Scenes/MagnifierShowcase.unity
Show resolved
Hide resolved
Cameron-Micka
approved these changes
Dec 13, 2022
...icrosoft.mrtk.graphicstools.unity/Runtime/Experimental/Magnifier/Scripts/MagnifierManager.cs
Outdated
Show resolved
Hide resolved
...icrosoft.mrtk.graphicstools.unity/Runtime/Experimental/Magnifier/Scripts/MagnifierManager.cs
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A custom render feature for the URP that works somewhat like Unity’s “grab pass” feature to help magnify the screen in stereo rendering contexts.
Motivation
In reference to #66 this is an accessibility tool akin to the Magnifier in SeeingVR to Make Virtual Reality More Accessible to People with Low Vision