Skip to content

Commit 5bf61a5

Browse files
Light Combiner Package Fix (#241)
1 parent a679a98 commit 5bf61a5

File tree

3 files changed

+29
-3
lines changed

3 files changed

+29
-3
lines changed

com.microsoft.mrtk.graphicstools.unity/CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,21 @@ All notable changes to this package will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
66

7+
## [0.8.8] - 2025-05-29
8+
9+
### Changed
10+
11+
- Fixed a bug where scenes in packages could not be light combined.
12+
13+
## [0.8.7] - 2025-04-23
14+
15+
### Changed
16+
17+
- Fixed a bug where source and destination blend alpha were not maintained when "Allow Material override" was checked.
18+
- Fixed a Unity 2021 shader compilation error.
19+
- Acrylic bug fix, UNITY_UV_STARTS_AT_TOP is always defined, so the previous check was incorrect.
20+
- @vmoras6699 changed the scalable shader graph target's unlit low shader path to use baked lit.
21+
722
## [0.8.6] - 2025-04-21
823

924
### Changed

com.microsoft.mrtk.graphicstools.unity/Editor/LightCombiner/LightCombinerWindow.cs

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,19 @@ private void Save()
125125
}
126126

127127
// Generate a new path for the duplicated scene.
128-
var newScenePath = Path.Combine(Path.GetDirectoryName(currentScenePath),
129-
Path.GetFileNameWithoutExtension(currentScenePath) + $"_{kWorkingDirectoryPostfix}.unity");
128+
string newScenePath;
129+
if (currentScenePath.Replace('\\', '/').StartsWith("Packages/"))
130+
{
131+
// Place at the root of the Assets folder if the scene is from a package.
132+
// For the case of immutable packages and EditorSceneManager.OpenScene has trouble opening scenes in packages.
133+
newScenePath = Path.Combine("Assets",
134+
Path.GetFileNameWithoutExtension(currentScenePath) + $"_{kWorkingDirectoryPostfix}.unity");
135+
}
136+
else
137+
{
138+
newScenePath = Path.Combine(Path.GetDirectoryName(currentScenePath),
139+
Path.GetFileNameWithoutExtension(currentScenePath) + $"_{kWorkingDirectoryPostfix}.unity");
140+
}
130141

131142
if (AssetDatabase.CopyAsset(currentScenePath, newScenePath))
132143
{

com.microsoft.mrtk.graphicstools.unity/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "com.microsoft.mrtk.graphicstools.unity",
3-
"version": "0.8.7",
3+
"version": "0.8.8",
44
"displayName": "MRTK Graphics Tools",
55
"description": "Graphics tools and components for developing Mixed Reality applications in Unity.",
66
"documentationUrl": "https://aka.ms/mrtk3graphics",

0 commit comments

Comments
 (0)