Merged PR 39167: [BR] DXGI error code mapping; tighter packing for non-planar resources

* Map DXGI HRESULTS to D3DERR/D3DDDIERR HRESULTS so that d3d9 apps can react appropriately ([#102](#102) )
* Contain dxgi error code mapping fix
* Remove debug assert in ConvertBoxToRect ([#103](#103))
* Contain debug assert fix
* Use tighter packing for non-planar resources ([#105](#105))
* Contain tighter packing for non-planar resources change

Backport bug: https://microsoft.visualstudio.com/OS/_workitems/edit/61561225/

----
#### AI description  (iteration 1)
#### PR Classification
This pull request implements an API enhancement by optimizing non-planar resource packing and improving DXGI error code translation for D3D9.

#### PR Summary
The changes introduce a feature-flag-controlled tighter packing strategy in resource memory layout and add a new inline function to map DXGI error codes to their D3D9 counterparts, ensuring more efficient error handling and resource management.
- **`src/9on12Resource.cpp`**: Implements tighter packing for non-planar resources by recalculating row pitches and total size when the feature is enabled.
- **`include/9on12Util.h`**: Adds the `TranslateDxgiHrToD3D9` function and updates error handling macros to use a cached feature flag for efficient DXGI error translation.
- **`src/9on12Blit.cpp`**: Adjusts the box-to-rectangle conversion check to conditionally bypass strict validations based on the feature flag.
- **`src/CMakeLists.txt` & `include/pch.h`**: Update build dependencies and include directories to support the new feature integration.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->

Author: vdwtanner

include/9on12Util.h

@@ -87,6 +87,26 @@ namespace D3D9on12
         Value value;
     };
 
+    //
+    // Translates DXGI error codes to their D3D9 equivalents so that the
+    // correct HRESULTs propagate to the D3D9 runtime.  Non-DXGI codes pass
+    // through unchanged.
+    //
+    // Not an exhuastive list, but the ones most likely to be hit
+    //
+    inline HRESULT TranslateDxgiHrToD3D9(HRESULT hr)
+    {
+        switch (hr)
+        {
+        case DXGI_ERROR_DEVICE_REMOVED:         return D3DDDIERR_DEVICEREMOVED;
+        case DXGI_ERROR_DEVICE_HUNG:            return D3DERR_DEVICEHUNG;
+        case DXGI_ERROR_DEVICE_RESET:           return D3DERR_DEVICELOST;
+        case DXGI_ERROR_DRIVER_INTERNAL_ERROR:  return D3DERR_DRIVERINTERNALERROR;
+        case DXGI_ERROR_INVALID_CALL:           return D3DERR_DRIVERINTERNALERROR; // This is a driver error from the app's perspective as it means that 9on12 made an invalid call
+        default:                                return hr;
+        }
+    }
+
 #define D3D9on12_DDI_ENTRYPOINT_START(implemented) \
 __pragma(warning(suppress:4127)) /* conditional is constant due to constant macro parameter(s) */ \
     if((implemented) == false && RegistryConstants::g_cBreakOnMissingDDI) \
@@ -103,6 +123,7 @@ __pragma(warning(suppress:4127)) /* conditional is constant due to constant macr
     try \
     { \
 
+	static bool g_Feature_K2FixesRound1_IsEnabled = Feature_K2FixesRound1::IsEnabled(); // cache this value since it's used in a lot of entry points and is weirdly expensive to call
 #define CLOSE_TRYCATCH_AND_STORE_HRESULT(hr) \
         EntryPointHr = hr; \
     } \
@@ -114,6 +135,9 @@ __pragma(warning(suppress:4127)) /* conditional is constant due to constant macr
     { \
         EntryPointHr = E_OUTOFMEMORY; \
     } \
+    if(g_Feature_K2FixesRound1_IsEnabled) {\
+        EntryPointHr = TranslateDxgiHrToD3D9(EntryPointHr); \
+    } \
 
 #define D3D9on12_DDI_ENTRYPOINT_END_AND_RETURN_HR(hr) \
     CLOSE_TRYCATCH_AND_STORE_HRESULT(hr) \

include/pch.h

@@ -46,6 +46,9 @@
 #include <stack>
 #include <deque>
 
+#define WIL_SUPPRESS_PRIVATE_API_USE
+#include "FeatureStaging-D3DCD.h"
+
 
 #define BIT( x ) ( 1 << (x) )
 #if DBG

src/9on12Blit.cpp

@@ -441,8 +441,10 @@ namespace D3D9on12
 
     static inline D3D12_RECT ConvertBoxToRect(const D3D12_BOX& box)
     {
-        Check9on12(box.front == 0 && box.back == 1);
-
+        if (!Feature_K2FixesRound1::IsEnabled())
+        {
+            Check9on12(box.front == 0 && box.back == 1);
+        }
         D3D12_RECT rect =
         {
             static_cast<LONG>(box.left), 

src/9on12Resource.cpp

@@ -900,6 +900,30 @@ namespace D3D9on12
             &m_physicalLinearRepresentation.m_rowPitces[0],
             &m_totalSize);
 
+        if (Feature_K2FixesRound1::IsEnabled())
+        {
+            // If unrestricted pitch is supported, we can use tighter packing for non-planar resources
+            // instead of the default 256-byte alignment that GetCopyableFootprints applies
+            if (m_pParentDevice->GetContext().GetOptions13().UnrestrictedBufferTextureCopyPitchSupported && m_NonOpaquePlaneCount == 1)
+            {
+                m_totalSize = 0;
+                for (UINT subresourceIndex = 0; subresourceIndex < m_numSubresources; subresourceIndex++)
+                {
+                    auto& footprint = m_physicalLinearRepresentation.m_footprints[subresourceIndex];
+
+                    UINT minPitch = 0;
+                    CD3D11FormatHelper::CalculateMinimumRowMajorRowPitch(footprint.Footprint.Format, footprint.Footprint.Width, minPitch);
+                    footprint.Footprint.RowPitch = minPitch;
+                    m_physicalLinearRepresentation.m_rowPitces[subresourceIndex] = minPitch; // Even though we don't use the m_rowPitches field, keep it consistent with the newly computed RowPitch
+                    footprint.Offset = m_totalSize;
+                    
+                    UINT slicePitch = 0;
+                    CD3D11FormatHelper::CalculateMinimumRowMajorSlicePitch(footprint.Footprint.Format, footprint.Footprint.RowPitch, footprint.Footprint.Height, slicePitch);
+                    m_totalSize += UINT64(slicePitch) * footprint.Footprint.Depth;
+                }
+            }
+        }
+
         // We can safely skip initializing app memory information if only the first surf is 
         // initialized because this only happens as when we internally create this resource 
         // and won't be working with any app initial memory

src/CMakeLists.txt

@@ -25,6 +25,11 @@ FetchContent_MakeAvailable(d3d12translationlayer)
 target_link_libraries(d3d9on12 d3d12translationlayer_wdk)
 target_link_libraries(d3d9on12 d3d9on12_shaderconv)
 
+# KIR dependencies
+target_link_libraries(d3d12translationlayer Microsoft.Windows.Wil.Internal shcore.lib)
+add_dependencies(d3d12translationlayer FeatureStaging-D3DCD)
+target_include_directories(d3d9on12 PRIVATE "${Direct3DMappingLayers_BINARY_DIR}/include/")
+
 if(TARGET dxbcsigner_static)
     target_link_libraries(d3d9on12 dxbcsigner_static)
 else()