Merged PR 726586: Close HistoricMetadataCache after we finish workers

We intentionally close the cache (including HistoricMetadataCache - HMC) after we finish the workers. We might report PathSets coming from the workers to HMC, so it is important for HMC to be active.

This is to resolve those warnings: https://dev.azure.com/mseng/Domino/_build/results?buildId=20522946&view=logs&j=253e5128-1058-5bd4-fdf1-9b556d3207f8&t=33cbe4a8-0d67-48ee-8ca4-2016dd25c0cc&l=36

Author: semihokur

Public/Src/Engine/Scheduler/Scheduler.cs

@@ -1682,8 +1682,6 @@ public async Task<bool> WhenDone()
                     Logger.Log.TopPipsPerformanceInfo(m_loggingContext, processPipPerf);
                 }
 
-                await State.Cache.CloseAsync();
-
                 var shutdownServicesSucceeded = await m_serviceManager.ShutdownStartedServices(Context.CancellationToken.IsCancellationRequested);
                 Contract.Assert(
                     shutdownServicesSucceeded || m_executePhaseLoggingContext.ErrorWasLogged,
@@ -1712,6 +1710,10 @@ public async Task<bool> WhenDone()
                     }
                 }
 
+                // We intentionally close the cache (including HistoricMetadataCache - HMC) after we finish the workers. 
+                // We might report PathSets coming from the workers to HMC, so it is important for HMC to be active.
+                await State.Cache.CloseAsync();
+
                 if (m_fingerprintStoreTarget != null)
                 {
                     // Dispose the fingerprint store to allow copying the files