Skip to content

Commit 7b2936f

Browse files
smeraschandr78
authored andcommitted
Merged PR 716623: Add missing dependency for Microsoft.Identity.Client
The nuget generation logic seems to have a problem with a particular dependency, and even though Microsoft.IdentityModel lists Microsoft.IdentityModel.Abstractions as a dependency, the generated nuget spec does not include the latter for net6 (it does for other frameworks). Patching this manually by including the missing dependency explicitly. We'll file a bug for fixing the root cause.
1 parent fc72e4c commit 7b2936f

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

Public/Src/Cache/DistributedCache.Host/LauncherServer/BuildXL.Launcher.Server.dsc

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ namespace LauncherServer {
3030
importFrom("Azure.Identity").pkg,
3131
importFrom("Azure.Core").pkg,
3232
importFrom("Microsoft.Identity.Client").pkg,
33+
// TODO: this should be part of Microsoft.Identity.Client dependencies, but there seems to be a bug in the spec generation and the dependency is left out.
34+
importFrom("Microsoft.IdentityModel.Abstractions").pkg,
3335

3436
...importFrom("BuildXL.Cache.ContentStore").getGrpcPackages(true),
3537
...importFrom("BuildXL.Cache.ContentStore").getGrpcAspNetCorePackages(),

Public/Src/Cache/Monitor/Library/BuildXL.Cache.Monitor.Library.dsc

+2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ namespace Library {
3232
importFrom("System.Private.ServiceModel").pkg,
3333
importFrom("System.ServiceModel.Http").pkg,
3434
importFrom("Microsoft.Identity.Client").pkg,
35+
// TODO: this should be part of Microsoft.Identity.Client dependencies, but there seems to be a bug in the spec generation and the dependency is left out.
36+
importFrom("Microsoft.IdentityModel.Abstractions").pkg,
3537

3638
importFrom("Azure.Identity").pkg,
3739
importFrom("Azure.Core").pkg,

Public/Src/Utilities/Authentication/BuildXL.Utilties.Authentication.dsc

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ namespace Authentication {
1010
Utilities.Core.dll,
1111
importFrom("Newtonsoft.Json").pkg,
1212
importFrom("Microsoft.Identity.Client").pkg,
13+
// TODO: this should be part of Microsoft.Identity.Client dependencies, but there seems to be a bug in the spec generation and the dependency is left out.
14+
importFrom("Microsoft.IdentityModel.Abstractions").pkg,
1315
importFrom("Microsoft.Identity.Client.Extensions.Msal").pkg,
1416
importFrom("Microsoft.IdentityModel.Clients.ActiveDirectory").pkg,
1517
importFrom("Microsoft.VisualStudio.Services.Client").pkg,

0 commit comments

Comments
 (0)