diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertingSubsystemInit.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertingSubsystemInit.java index 0b8f5e19461..123b562c2f7 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertingSubsystemInit.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertingSubsystemInit.java @@ -38,7 +38,7 @@ public class AlertingSubsystemInit { // TODO (trask) inject instead of using global private static volatile AlertingSubsystem alertingSubsystem; - private static final Logger logger = LoggerFactory.getLogger(AlertingSubsystem.class); + private static final Logger logger = LoggerFactory.getLogger(AlertingSubsystemInit.class); public static AlertingSubsystem create( Configuration.ProfilerConfiguration configuration, diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/GcEventInit.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/GcEventInit.java index 81592d06c8a..08ff33fe694 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/GcEventInit.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/GcEventInit.java @@ -101,7 +101,7 @@ private static void sendTenuredFillPercentageToAlerting( long currentLevel = tenuredUsage.getUsed(); long max = tenuredUsage.getMax(); if (max > 0) { - double percentage = 100.0 * (double) currentLevel / (double) max; + double percentage = 100.0 * currentLevel / max; alertingSubsystem.track(AlertMetricType.MEMORY, percentage); } } diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/OsPlatformProvider.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/OsPlatformProvider.java index 15727ca5c95..c313edb1f89 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/OsPlatformProvider.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/OsPlatformProvider.java @@ -30,11 +30,11 @@ public static String getOsPlatformDescription() { } private static boolean isWindows() { - return getOsName().startsWith("Windows"); + return getOsName().startsWith(WINDOWS); } private static boolean isLinux() { - return getOsName().startsWith("Linux") || getOsName().startsWith("LINUX"); + return getOsName().startsWith(LINUX) || getOsName().startsWith("LINUX"); } private static boolean isMac() { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/ServiceLoaderUtil.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/ServiceLoaderUtil.java index b8ee0700fd0..e83bcaba729 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/ServiceLoaderUtil.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/util/ServiceLoaderUtil.java @@ -17,7 +17,7 @@ public static T findServiceLoader(Class clazz) { public static T findServiceLoader(Class clazz, boolean includeExtensionClassPath) { List services = findAllServiceLoaders(clazz, includeExtensionClassPath); - if (services.size() > 0) { + if (!services.isEmpty()) { return services.get(0); } return null;