Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pull Request Handler redownloads artifacts to compiler folder despite using explicit, static artifact URL #1420

Open
cegekaJG opened this issue Jan 27, 2025 · 1 comment
Labels
bug Something isn't working Fix Ready Fix Ready

Comments

@cegekaJG
Copy link
Contributor

AL-Go version

6.0

Describe the issue

Since several of our projects are OnPrem for a single environment, we explicitly define artifact URLs when possible for our AL Go projects. However, despite the fact that the BC artifact therefore never changes, roughly 20% of all runs of the action "Pull Request Handler" will still take significantly longer setting up the compiler folder, effectively doubling the runtime of the workflow.

Expected behavior

The workflow should have similar runtimes.
If there is something like a timer to an automatic reset of the complier folder, there should be a way to either circumvent this or trigger it in a separate workflow to keep runtimes consistent, as they otherwise take too long for some time-sensitive tasks.

Steps to reproduce

Here are my settings:

.AL-Go/settings.json

{
  "$schema": "https://raw.githubusercontent.com/microsoft/AL-Go/v5.1/Schema/algosettingssyntax.json",
  "artifact": "https://bcartifacts-exdbf9fwegejdqak.b02.azurefd.net/sandbox/25.1.25873.26735/at",
  "country": "at",
  "generateDependencyArtifact": true
}

.github/AL-Go-Settings.json

{
  "$schema": "https://raw.githubusercontent.com/microsoft/AL-Go/v5.1/Schema/algoreposettingssyntax.json",
  "buildModes": [
    "Default"
  ],
  "customCodeCops": [
    "https://github.com/StefanMaron/BusinessCentral.LinterCop/releases/latest/download/BusinessCentral.LinterCop.current.dll"
  ],
  "doNotPublishApps": true,
  "enableCodeCop": true,
  "enableExternalRulesets": true,
  "enablePerTenantExtensionCop": false,
  "enableUICop": true,
  "githubRunner": "ubuntu-latest",
  "runs-on": "ubuntu-latest",
  "skipUpgrade": true,
  "templateUrl": "https://github.com/CBS-BC-AT/AL-Go@cegeka6",
  "templateFiles": [
    ".github/DeployTo*.ps1",
    ".schemas/*"
  ],
  "type": "PTE",
  "UpdateGitHubGoSystemFilesSchedule": "0 2 * * 1",
  "useCompilerFolder": true,
  "vsixFile": "latest"
}

To reproduce, starting multiple status checks of a pull request in a repo using these settings would be required. I have yet to find any pattern on which runs will take longer to complete, or even if it only applies to certain pull requests.

Additional context (logs, screenshots, etc.)

Run with normal execution time

Run with slow execution time

@cegekaJG cegekaJG added the bug Something isn't working label Jan 27, 2025
@freddydk
Copy link
Contributor

It looks like we are hitting the download limit on the bcartifacts - which says maximum 1000 downloads per minut.
I have increased the limit to 5000 - lets see if this still happens.

@freddydk freddydk added the Fix Ready Fix Ready label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fix Ready Fix Ready
Projects
None yet
Development

No branches or pull requests

2 participants