Skip to content
This repository was archived by the owner on Dec 5, 2023. It is now read-only.

Commit b5ec77e

Browse files
authored
Merge pull request #48 from microservices-demo/update-go-1.7
Changed necessary to work with go 1.7
2 parents 5e88df6 + 1b64efd commit b5ec77e

File tree

6 files changed

+13
-26
lines changed

6 files changed

+13
-26
lines changed

api/endpoints.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ package api
55
// transport.
66

77
import (
8+
"context"
9+
810
"github.com/go-kit/kit/endpoint"
911
"github.com/go-kit/kit/tracing/opentracing"
1012
"github.com/microservices-demo/user/db"
1113
"github.com/microservices-demo/user/users"
1214
stdopentracing "github.com/opentracing/opentracing-go"
13-
"golang.org/x/net/context"
1415
)
1516

1617
// Endpoints collects the endpoints that comprise the Service.

api/transport.go

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ package api
44
// In our case we just use a REST-y HTTP transport.
55

66
import (
7+
"context"
78
"encoding/json"
89
"errors"
910
"net/http"
@@ -16,15 +17,14 @@ import (
1617
"github.com/microservices-demo/user/users"
1718
stdopentracing "github.com/opentracing/opentracing-go"
1819
"github.com/prometheus/client_golang/prometheus/promhttp"
19-
"golang.org/x/net/context"
2020
)
2121

2222
var (
2323
ErrInvalidRequest = errors.New("Invalid request")
2424
)
2525

2626
// MakeHTTPHandler mounts the endpoints into a REST-y HTTP handler.
27-
func MakeHTTPHandler(ctx context.Context, e Endpoints, logger log.Logger, tracer stdopentracing.Tracer) *mux.Router {
27+
func MakeHTTPHandler(e Endpoints, logger log.Logger, tracer stdopentracing.Tracer) *mux.Router {
2828
r := mux.NewRouter().StrictSlash(false)
2929
options := []httptransport.ServerOption{
3030
httptransport.ServerErrorLogger(logger),
@@ -36,70 +36,60 @@ func MakeHTTPHandler(ctx context.Context, e Endpoints, logger log.Logger, tracer
3636
// GET /health Health Check
3737

3838
r.Methods("GET").Path("/login").Handler(httptransport.NewServer(
39-
ctx,
4039
e.LoginEndpoint,
4140
decodeLoginRequest,
4241
encodeResponse,
4342
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /login", logger)))...,
4443
))
4544
r.Methods("POST").Path("/register").Handler(httptransport.NewServer(
46-
ctx,
4745
e.RegisterEndpoint,
4846
decodeRegisterRequest,
4947
encodeResponse,
5048
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /register", logger)))...,
5149
))
5250
r.Methods("GET").PathPrefix("/customers").Handler(httptransport.NewServer(
53-
ctx,
5451
e.UserGetEndpoint,
5552
decodeGetRequest,
5653
encodeResponse,
5754
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /customers", logger)))...,
5855
))
5956
r.Methods("GET").PathPrefix("/cards").Handler(httptransport.NewServer(
60-
ctx,
6157
e.CardGetEndpoint,
6258
decodeGetRequest,
6359
encodeResponse,
6460
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /cards", logger)))...,
6561
))
6662
r.Methods("GET").PathPrefix("/addresses").Handler(httptransport.NewServer(
67-
ctx,
6863
e.AddressGetEndpoint,
6964
decodeGetRequest,
7065
encodeResponse,
7166
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /addresses", logger)))...,
7267
))
7368
r.Methods("POST").Path("/customers").Handler(httptransport.NewServer(
74-
ctx,
7569
e.UserPostEndpoint,
7670
decodeUserRequest,
7771
encodeResponse,
7872
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /customers", logger)))...,
7973
))
8074
r.Methods("POST").Path("/addresses").Handler(httptransport.NewServer(
81-
ctx,
8275
e.AddressPostEndpoint,
8376
decodeAddressRequest,
8477
encodeResponse,
8578
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /addresses", logger)))...,
8679
))
8780
r.Methods("POST").Path("/cards").Handler(httptransport.NewServer(
88-
ctx,
8981
e.CardPostEndpoint,
9082
decodeCardRequest,
9183
encodeResponse,
9284
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /cards", logger)))...,
9385
))
9486
r.Methods("DELETE").PathPrefix("/").Handler(httptransport.NewServer(
95-
ctx,
9687
e.DeleteEndpoint,
9788
decodeDeleteRequest,
9889
encodeResponse,
9990
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "DELETE /", logger)))...,
10091
))
10192
r.Methods("GET").PathPrefix("/health").Handler(httptransport.NewServer(
102-
ctx,
10393
e.HealthEndpoint,
10494
decodeHealthRequest,
10595
encodeHealthResponse,

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ services:
1616
- MONGO_HOST=user-db:27017
1717
- reschedule=on-node-failure
1818
ports:
19-
- "8080:8084"
19+
- "8080:80"
2020
user-db:
2121
build:
2222
context: ./docker/user-db/

glide.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

glide.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package: github.com/microservices-demo/user
22
import:
33
- package: github.com/go-kit/kit
4+
version: v0.4.0
45
subpackages:
56
- endpoint
67
- log
@@ -16,9 +17,6 @@ import:
1617
subpackages:
1718
- prometheus
1819
- prometheus/promhttp
19-
- package: golang.org/x/net
20-
subpackages:
21-
- context
2220
- package: gopkg.in/mgo.v2
2321
subpackages:
2422
- bson

main.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
zipkin "github.com/openzipkin/zipkin-go-opentracing"
2020
stdprometheus "github.com/prometheus/client_golang/prometheus"
2121
commonMiddleware "github.com/weaveworks/common/middleware"
22-
"golang.org/x/net/context"
2322
)
2423

2524
var (
@@ -51,22 +50,21 @@ func main() {
5150
flag.Parse()
5251
// Mechanical stuff.
5352
errc := make(chan error)
54-
ctx := context.Background()
5553

5654
// Log domain.
5755
var logger log.Logger
5856
{
5957
logger = log.NewLogfmtLogger(os.Stderr)
60-
logger = log.NewContext(logger).With("ts", log.DefaultTimestampUTC)
61-
logger = log.NewContext(logger).With("caller", log.DefaultCaller)
58+
logger = log.With(logger, "ts", log.DefaultTimestampUTC)
59+
logger = log.With(logger, "caller", log.DefaultCaller)
6260
}
6361

6462
var tracer stdopentracing.Tracer
6563
{
6664
if zip == "" {
6765
tracer = stdopentracing.NoopTracer{}
6866
} else {
69-
logger := log.NewContext(logger).With("tracer", "Zipkin")
67+
logger := log.With(logger, "tracer", "Zipkin")
7068
logger.Log("addr", zip)
7169
collector, err := zipkin.NewHTTPCollector(
7270
zip,
@@ -128,7 +126,7 @@ func main() {
128126
endpoints := api.MakeEndpoints(service, tracer)
129127

130128
// HTTP router
131-
router := api.MakeHTTPHandler(ctx, endpoints, logger, tracer)
129+
router := api.MakeHTTPHandler(endpoints, logger, tracer)
132130

133131
httpMiddleware := []commonMiddleware.Interface{
134132
commonMiddleware.Instrument{

0 commit comments

Comments
 (0)