Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using Makefile to build binaries #130

Closed
Harsh4902 opened this issue Mar 18, 2025 · 6 comments
Closed

Start using Makefile to build binaries #130

Harsh4902 opened this issue Mar 18, 2025 · 6 comments
Labels
Milestone

Comments

@Harsh4902
Copy link

Reason/Context

Description

  • We have to use Makefile and will replace it with build-binaries.sh, and we can define deferent steps like build, test in Makefile.

Implementation ideas

No response

@Rupam-It
Copy link

Hey @Harsh4902 can i work with you in this issue also for the CI/CD part ?

@Harsh4902
Copy link
Author

@Rupam-It Yes why not. Please share your thoughts here and we'll discuss on it.

@Rupam-It
Copy link

thanks @Harsh4902 ,
so for now we can create a Makefile that consist the same functionality of build-binaries.sh!
and for test I think there is no test file present in the codebase so we have to add test file also !

@Harsh4902
Copy link
Author

Harsh4902 commented Mar 21, 2025

thanks @Harsh4902 , so for now we can create a Makefile that consist the same functionality of build-binaries.sh! and for test I think there is no test file present in the codebase so we have to add test file also !

Yes, exactly. If you can add unit tests for existing commands, then it would be great. I have also created an issue #132 for this.

@Rupam-It
Copy link

thanks @Harsh4902 , so for now we can create a Makefile that consist the same functionality of build-binaries.sh! and for test I think there is no test file present in the codebase so we have to add test file also !

Yes, exactly. If you can add unit tests for existing commands, then it would be great. I have also created an issue #132 for this.

okk, that cool. i'm working on it ! (creating test file )
and i have already make a Makefile !

@lbroudoux lbroudoux added this to the 1.0.0 milestone Mar 21, 2025
Harsh4902 added a commit to Harsh4902/microcks-cli that referenced this issue Mar 23, 2025
lbroudoux pushed a commit that referenced this issue Apr 2, 2025
@lbroudoux
Copy link
Member

Now closed per #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants