Avoid having part of the methods static and the other part instance

While this is a breaking change, I had a look at the impact in the
Ecosystem and it looks like it wouldn't break too many components.

Author: gsmet

core/runtime/src/main/java/io/quarkus/runtime/LaunchMode.java

@@ -24,17 +24,6 @@ public enum LaunchMode {
     public static final String PROD_PROFILE = "prod";
     public static final String TEST_PROFILE = "test";
 
-    public static boolean isDev() {
-        return current() == DEVELOPMENT;
-    }
-
-    /**
-     * Returns true if the current launch is the server side of remote dev.
-     */
-    public static boolean isRemoteDev() {
-        return (current() == DEVELOPMENT) && "true".equals(System.getenv("QUARKUS_LAUNCH_DEVMODE"));
-    }
-
     private final String defaultProfile;
     private final String profileKey;
     private final boolean devServicesSupported;
@@ -56,6 +45,17 @@ public String getProfileKey() {
         return profileKey;
     }
 
+    public boolean isDev() {
+        return this == DEVELOPMENT;
+    }
+
+    /**
+     * Returns true if the current launch is the server side of remote dev.
+     */
+    public boolean isRemoteDev() {
+        return (this == DEVELOPMENT) && "true".equals(System.getenv("QUARKUS_LAUNCH_DEVMODE"));
+    }
+
     public boolean isDevOrTest() {
         return this == DEVELOPMENT || this == TEST;
     }

extensions/agroal/runtime-dev/src/main/java/io/quarkus/agroal/runtime/dev/ui/DatabaseInspector.java

@@ -52,7 +52,7 @@ public final class DatabaseInspector {
 
     public DatabaseInspector() {
         LaunchMode currentMode = LaunchMode.current();
-        this.isDev = currentMode == LaunchMode.DEVELOPMENT && !LaunchMode.isRemoteDev();
+        this.isDev = currentMode.isDev() && !currentMode.isRemoteDev();
 
         Config config = ConfigProvider.getConfig();
         this.allowSql = config.getOptionalValue("quarkus.datasource.dev-ui.allow-sql", Boolean.class)

extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/dev/HibernateOrmDevJsonRpcService.java

@@ -36,7 +36,7 @@ public class HibernateOrmDevJsonRpcService {
     private String allowedHost;
 
     public HibernateOrmDevJsonRpcService() {
-        this.isDev = LaunchMode.current() == LaunchMode.DEVELOPMENT && !LaunchMode.isRemoteDev();
+        this.isDev = LaunchMode.current().isDev() && !LaunchMode.current().isRemoteDev();
         this.allowedHost = ConfigProvider.getConfig()
                 .getOptionalValue("quarkus.datasource.dev-ui.allowed-db-host", String.class)
                 .orElse(null);

extensions/resteasy-classic/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/AuthenticationCompletionExceptionMapper.java

@@ -17,7 +17,7 @@ public class AuthenticationCompletionExceptionMapper implements ExceptionMapper<
     @Override
     public Response toResponse(AuthenticationCompletionException ex) {
         log.debug("Authentication has failed, returning HTTP status 401");
-        if (LaunchMode.isDev() && ex.getMessage() != null) {
+        if (LaunchMode.current().isDev() && ex.getMessage() != null) {
             return Response.status(401).entity(ex.getMessage()).build();
         }
         return Response.status(401).build();

extensions/resteasy-classic/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/AuthenticationFailedExceptionMapper.java

@@ -45,7 +45,7 @@ public Response toResponse(AuthenticationFailedException exception) {
                 if (challengeData != null && challengeData.headerName != null) {
                     responseBuilder.header(challengeData.headerName.toString(), challengeData.headerContent);
                 }
-                if (LaunchMode.isDev() && exception.getMessage() != null && statusCode == 401) {
+                if (LaunchMode.current().isDev() && exception.getMessage() != null && statusCode == 401) {
                     responseBuilder.entity(exception.getMessage());
                 }
                 log.debugf("Returning an authentication challenge, status code: %d", statusCode);
@@ -56,7 +56,7 @@ public Response toResponse(AuthenticationFailedException exception) {
         } else {
             log.error("RoutingContext is not found, returning HTTP status 401");
         }
-        if (LaunchMode.isDev() && exception.getMessage() != null) {
+        if (LaunchMode.current().isDev() && exception.getMessage() != null) {
             return Response.status(401).entity(exception.getMessage()).build();
         }
         return Response.status(401).entity("Not Authenticated").build();

extensions/resteasy-reactive/rest/runtime/src/main/java/io/quarkus/resteasy/reactive/server/runtime/exceptionmappers/AuthenticationCompletionExceptionMapper.java

@@ -10,7 +10,7 @@ public class AuthenticationCompletionExceptionMapper implements ExceptionMapper<
 
     @Override
     public Response toResponse(AuthenticationCompletionException ex) {
-        if (LaunchMode.isDev() && ex.getMessage() != null) {
+        if (LaunchMode.current().isDev() && ex.getMessage() != null) {
             return Response.status(Response.Status.UNAUTHORIZED).entity(ex.getMessage()).build();
         }
         return Response.status(Response.Status.UNAUTHORIZED).build();

extensions/resteasy-reactive/rest/runtime/src/main/java/io/quarkus/resteasy/reactive/server/runtime/exceptionmappers/AuthenticationFailedExceptionMapper.java

@@ -18,6 +18,6 @@ public class AuthenticationFailedExceptionMapper {
     public Uni<Response> handle(RoutingContext routingContext, AuthenticationFailedException exception) {
         addAuthenticationFailureToEvent(exception, routingContext);
         return SecurityExceptionMapperUtil.handleWithAuthenticator(routingContext,
-                LaunchMode.isDev() ? exception.getMessage() : null);
+                LaunchMode.current().isDev() ? exception.getMessage() : null);
     }
 }

extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/QuarkusErrorHandler.java

@@ -124,7 +124,7 @@ public void accept(Throwable throwable) {
                 if ((exception instanceof AuthenticationCompletionException
                         || (exception instanceof AuthenticationFailedException && event.response().getStatusCode() == 401))
                         && exception.getMessage() != null
-                        && LaunchMode.isDev()) {
+                        && LaunchMode.current().isDev()) {
                     event.response().end(exception.getMessage());
                 } else {
                     event.response().end();

extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxConfigBuilder.java

@@ -25,7 +25,7 @@ private static void defineHttpInterface(SmallRyeConfigBuilder builder, String co
         }
 
         // Sets the default host config value, depending on the launch mode
-        if (LaunchMode.isRemoteDev()) {
+        if (LaunchMode.current().isRemoteDev()) {
             // in remote dev mode, we want to listen on all interfaces
             // to make sure the application is accessible
             builder.withDefaultValue(configurationProperty, ALL_INTERFACES);

extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/security/HttpSecurityRecorder.java

@@ -218,7 +218,7 @@ public void accept(RoutingContext event, Throwable throwable) {
                 return;
             }
             throwable = extractRootCause(throwable);
-            if (LaunchMode.isDev() && throwable instanceof AuthenticationException
+            if (LaunchMode.current().isDev() && throwable instanceof AuthenticationException
                     && throwable.getMessage() != null) {
                 event.put(DEV_MODE_AUTHENTICATION_FAILURE_BODY, throwable.getMessage());
             }