Merge of Tanstack/DB replacing Query, and Playwright tests #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should remove these before merging to main, but will keep them during QA because these hanging bugs are a little difficult to predict and reproduce. Sometimes when submitting a form, the form goes into "submitting" (disabled) state, but there's no network request and no Zod error. Refreshing often fixes it, but we really want to get rid of these errors before we ship.
This should be a distinction without a difference, but just to be safe, we are now mirroring this structure directly: https://tanstack.com/router/v1/docs/framework/react/how-to/setup-auth-providers#4-update-app-configuration
Merge the `tanstack/db` branch, converting everything to live queries
* Add Playwright for e2e testing * Add super basic test for the login to ensure auth guard and redirect are working * Add spec for add-phrase & bulk-add-phrases * Add stubs for specs for all mutations across the app * Add proper types to the db-helpers file * Add working cards spec to test card status dropdown and heart icon * Document the pattern to check results in both the DB and UI * Add requests spec * Always put toasts last so we can use them to await interactions * Write up some ideas for ideal testing framework * Add spec for decks * Add reviews.spec, and both-helpers to compare db to local * Make everything less flakey
mhsnook
changed the title
Owner
Author
|
As of now, we've got 17 out of 43 of these items covered by the test suite. Of the un-covered, all but two have been confirmed from human observation.
The first one I think we may just have to ship it and see. The second one I want to check prod -- if the bug exists there then we actually may not bother to solve it today and just ship this, and fix it first thing after (with a new test). Update: The bug is not present in production (phew) |
|
Updates to Preview Branch (next) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
This was referenced Dec 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing checklist:
Test rpc forms:
Collections based on views where we insert rows after create:
decksCollection:DeckMetaSchemaparse a new row fromuser_deckand match auser_deck_plusphrasesCollection:PhraseFullSchemaparse a new row fromphraseand match ameta_phrase_info(*, translations)cardsCollection:CardMetaSchemaparse a new row fromuser_cardand match auser_card_plusfriendSummariesCollection:FriendSummarySchemaparse a new row fromfriend_request_actionand match afriend_summaryMutations to check:
addTagsMutation🏗️addTranslationuseCardStatusMutationchangeMutationsendPhraseToFriendMutationsendRequestToFriendMutationuseFriendRequestActionuseReviewMutationuseSignOutuseNewDeckMutationrecoveryMutationloginMutationsignupMutationacceptOrDeclineMutationmainFormsendMessageMutationmutationaddPhraseMutationbulkAddMutation– works with multiple phrases with multiple translations (and shows the results below)updateDailyGoalMutationupdateDailyGoalMutationfulfillMutationcreateRequestMutationReviewPageSetupsendImageupdateProfilechangeMutationFunny Auth/Loading issues to check:
Checking logic under the hood: