From 2048af6d8a972cdad5228f44029f23a8ca5f8302 Mon Sep 17 00:00:00 2001
From: Andreu Genestar <andreu.genestar@gartner.com>
Date: Tue, 18 Feb 2020 11:32:42 +0100
Subject: [PATCH] Use tag instead of content_tag for links

---
 lib/scrivener/html/seo.ex        |  6 +++---
 test/scrivener/html/seo_test.exs | 20 --------------------
 2 files changed, 3 insertions(+), 23 deletions(-)

diff --git a/lib/scrivener/html/seo.ex b/lib/scrivener/html/seo.ex
index 6b0c689..05f0c96 100644
--- a/lib/scrivener/html/seo.ex
+++ b/lib/scrivener/html/seo.ex
@@ -41,7 +41,7 @@ defmodule Scrivener.HTML.SEO do
   call this function: [http://blog.danielberkompas.com/2016/01/28/seo-tags-in-phoenix.html](http://blog.danielberkompas.com/2016/01/28/seo-tags-in-phoenix.html)
 
       iex> Phoenix.HTML.safe_to_string(Scrivener.HTML.SEO.header_links(%Scrivener.Page{total_pages: 10, page_number: 3}))
-      "<link href=\"?page=2\" rel=\"prev\"></link>\n<link href=\"?page=4\" rel=\"next\"></link>"
+      "<link href=\"?page=2\" rel=\"prev\">\n<link href=\"?page=4\" rel=\"next\">"
   """
   def header_links(conn, %Page{page_number: 1} = paginator, args, opts) do
     next_header_link(conn, paginator, args, opts)
@@ -81,11 +81,11 @@ defmodule Scrivener.HTML.SEO do
 
   defp prev_header_link(conn, paginator, args, opts) do
     href = href(conn, paginator, args, opts, paginator.page_number - 1)
-    content_tag(:link, [], href: href, rel: rel(paginator, paginator.page_number - 1))
+    tag(:link, href: href, rel: rel(paginator, paginator.page_number - 1))
   end
 
   defp next_header_link(conn, paginator, args, opts) do
     href = href(conn, paginator, args, opts, paginator.page_number + 1)
-    content_tag(:link, [], href: href, rel: rel(paginator, paginator.page_number + 1))
+    tag(:link, href: href, rel: rel(paginator, paginator.page_number + 1))
   end
 end
diff --git a/test/scrivener/html/seo_test.exs b/test/scrivener/html/seo_test.exs
index b5cbad7..01fce4e 100644
--- a/test/scrivener/html/seo_test.exs
+++ b/test/scrivener/html/seo_test.exs
@@ -34,11 +34,6 @@ defmodule Scrivener.HTML.SEOTest do
                   60,
                   "link",
                   [[32, "href", 61, 34, "?page=2", 34], [32, "rel", 61, 34, "next", 34]],
-                  62,
-                  [],
-                  60,
-                  47,
-                  "link",
                   62
                 ]}
     end
@@ -50,11 +45,6 @@ defmodule Scrivener.HTML.SEOTest do
                   60,
                   "link",
                   [[32, "href", 61, 34, "?page=9", 34], [32, "rel", 61, 34, "prev", 34]],
-                  62,
-                  [],
-                  60,
-                  47,
-                  "link",
                   62
                 ]}
     end
@@ -67,11 +57,6 @@ defmodule Scrivener.HTML.SEOTest do
                     60,
                     "link",
                     [[32, "href", 61, 34, "?page=4", 34], [32, "rel", 61, 34, "prev", 34]],
-                    62,
-                    [],
-                    60,
-                    47,
-                    "link",
                     62
                   ],
                   "\n",
@@ -79,11 +64,6 @@ defmodule Scrivener.HTML.SEOTest do
                     60,
                     "link",
                     [[32, "href", 61, 34, "?page=6", 34], [32, "rel", 61, 34, "next", 34]],
-                    62,
-                    [],
-                    60,
-                    47,
-                    "link",
                     62
                   ]
                 ]}