Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align acidemia, alkalemia, acidosis, alkalosis with HPO #4012

Open
rays22 opened this issue Jul 18, 2024 · 2 comments
Open

Align acidemia, alkalemia, acidosis, alkalosis with HPO #4012

rays22 opened this issue Jul 18, 2024 · 2 comments
Labels
axiom HPO mapping mapping of MP to HP terms

Comments

@rays22
Copy link
Contributor

rays22 commented Jul 18, 2024

The relevant EQs have been fixed in HPO.

It would be great to alight the EQs of the related MP terms:

  1. increased acidity
  • MP:0003030 acidemia
  • MP:0003031 acidosis
    • suggested EQ (use blood or bodily fluid as appropriate):
    'has part' some 
        ('increased acidity'
         and ('characteristic of' some blood/bodily fluid)
         and ('has modifier' some abnormal))
    
  1. decreased acidity
  • MP:0003029 alkalemia
  • MP:0003028 alkalosis
    • suggested EQ (use blood or bodily fluid as appropriate):
    'has part' some 
        ('decreased acidity'
         and ('characteristic of' some blood/bodily flluid)
         and ('has modifier' some abnormal))
    
@sbello sbello added axiom HPO mapping mapping of MP to HP terms labels Jul 18, 2024
@anna-anagnostop
Copy link
Collaborator

Changed EQs for acidemia, acidosis, alkalemia and alkalosis.
Made acidemia a child of acidosis, and alkalemia a child of alkalosis.
Removed increased circulating methylmalonic acid level MP:0030630 from under acidemia CHECK
Need to review other child terms of acidosis and check EQ for lactic acidosis

anna-anagnostop added a commit that referenced this issue Jul 22, 2024
@sbello
Copy link
Contributor

sbello commented Jul 22, 2024

Acidosis and alkalosis are defined as increase in blood and tissues so we used multicellular organism in the eq. This is also why these are not parents of alkalemia and acidemia as this are limited to the blood.

Discussed on 8/26 - should the and really be and/or in the definitions. If it should be and/or the terms alkalemia and acidemia could be made child terms of these. If it is really 'and' then we would keep the current placement.

anna-anagnostop added a commit that referenced this issue Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
axiom HPO mapping mapping of MP to HP terms
Projects
None yet
Development

No branches or pull requests

3 participants