Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove departureTime from Carpool #12

Open
frankgerhardt opened this issue May 2, 2022 · 0 comments
Open

Remove departureTime from Carpool #12

frankgerhardt opened this issue May 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@frankgerhardt
Copy link
Member

Remove departureTime from Carpool, because it's a duplicate of the departureTime of the first Stop.
If both are in the schema, then both must have the same values which might not be the case always or needs extra work to enforce and check. They could be different, one of them could be null. What then? What has precendence? If there is only one departureTime there can not be any confusion. And there is always a first Stop where the time can be taken from.

@frankgerhardt frankgerhardt added the enhancement New feature or request label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant