4回目課題実装 #23
Open
4回目課題実装 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mf-sakura
reviewed
Apr 6, 2020
Owner
mf-sakura
left a comment
mf-sakura
left a comment
There was a problem hiding this comment.
@ntakashima
4回目の課題のレビューしました:pray:
|
|
||
| numbers := make([]*int, 0, 3) | ||
| for i := 0; i < 3; i++ { | ||
| i := i |
Comment on lines
+27
to
+38
| keys := make([]int, 0, len(studnetIDMap)) | ||
| for k := range studnetIDMap { | ||
| keys = append(keys, k) | ||
| } | ||
|
|
||
| for k, v := range studnetIDMap { | ||
| sort.Ints(keys) | ||
| for _, k := range keys { | ||
| // fmt.Printfでフォーマットに従った文字列を標準出力に出せる | ||
| fmt.Printf("Name of StudentID:%d is %s\n", k, studnetIDMap[k]) | ||
| } | ||
| } | ||
|
|
Comment on lines
+21
to
+25
| fmt.Printf("the address of n is %v\n", &n) | ||
| return n + 1 | ||
| } | ||
| func incrementWithPointer(n *int) { | ||
| fmt.Printf("the address of n is %v\n", &n) |
Owner
There was a problem hiding this comment.
main関数側のaddressもprintする必要がありました。
| } | ||
| // fileはCloseする必要がある。 | ||
| file.Close() | ||
| err = file.Close() |
Owner
There was a problem hiding this comment.
これだと他のエラーを上書きしてしまうので、
以下の様にnilで無ければ上書きする実装の方が良いと思います。
if closeErr := file.Close(); closeErr != nil {
err = closeErr
}
これでもfile.Close()がエラーを出した時は元のエラーを上書きしてしまうので、本当は2つのエラーを結合する処理が必要になります。ややこしいので講義では触れていません。
github.com/pkg/errorsを使った実装例
err = errors.Wrap(err, closeErr.Error())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.