Skip to content

Backport local recorder lifetime casting changes to 0.22 and 0.23. #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobz opened this issue Mar 27, 2025 · 1 comment
Closed

Backport local recorder lifetime casting changes to 0.22 and 0.23. #570

tobz opened this issue Mar 27, 2025 · 1 comment
Labels
C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-chore Type: chore.

Comments

@tobz
Copy link
Member

tobz commented Mar 27, 2025

Context

In #564, a rust-lang team member submitted changes to update a suboptimal instance of implicit lifetime casts that we use in LocalRecorderGuard<'a> related to change they were hoping to make upstream which would potentially turn such a usage into an error.

They mentioned that it would be useful to backport these changes as a patch release to older versions of metrics, given the notion that users on such versions might not be able to trivially update their metrics usage, but in backporting the change, it would ease the pain associated with making the aforementioned code pattern become an error.

It's pretty trivial to create backport branches, and the code involved is straightforward, so we should probably just do it once #564 is merged.

@tobz tobz added C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-chore Type: chore. labels Mar 27, 2025
@tobz
Copy link
Member Author

tobz commented Apr 21, 2025

This is done as of [email protected] and [email protected].

@tobz tobz closed this as completed Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-chore Type: chore.
Projects
None yet
Development

No branches or pull requests

1 participant