Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onlymap runs seem to fail with latest code #1509

Closed
charlienegri opened this issue Feb 8, 2025 · 1 comment · Fixed by #1510
Closed

onlymap runs seem to fail with latest code #1509

charlienegri opened this issue Feb 8, 2025 · 1 comment · Fixed by #1510
Assignees
@charlienegri
Labels
bug 🐛 Something isn't working

Comments

@charlienegri
Copy link
Collaborator

will run some more tests but it looks like with code @cams2-83_2025-02
the onlymap runs fail at the end with a variable error, e.g.

2025-02-08 11:54:47:pyaerocom.variable:1.1/1.3G:INFO:Unknown input variable CHIMERE
2025-02-08 11:54:47:pyaerocom.aeroval.experiment_output:1.1/1.3G:WARNING:Failed to infer cmap and variable ranges for CHIMERE, using default settings which are {'scale': [0.0, 1.25, 2.5, 3.75, 5.0, 6.25, 7.5, 8.75, 10.0], 'colmap': 'coolwarm'}
2025-02-08 11:54:47:pyaerocom.variable:1.1/1.3G:INFO:Unknown input variable CHIMERE
@charlienegri charlienegri self-assigned this Feb 9, 2025
@charlienegri charlienegri added the bug 🐛 Something isn't working label Feb 9, 2025
@charlienegri
Copy link
Collaborator Author

charlienegri commented Feb 9, 2025 •
edited
Loading

it seems like it's because of this https://github.com/metno/pyaerocom/blob/main-dev/pyaerocom/aeroval/experiment_output.py#L849
the output in the contour folder has now changed and this if https://github.com/metno/pyaerocom/blob/main-dev/pyaerocom/aeroval/experiment_output.py#L344 does not work anymore because len(spl) == 3 for geojsons too now

I will make a PR

@charlienegri charlienegri mentioned this issue Feb 9, 2025
Merged
9 tasks
@thorbjoernl thorbjoernl mentioned this issue Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlienegri charlienegri

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix logic to extract parameters from file names in the contour subfolder metno/pyaerocom
1 participant
@charlienegri