Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing configuration options and fix ansible lint errors #22

Open
wants to merge 79 commits into
base: trunk
Choose a base branch
from

Conversation

Lun4m
Copy link
Collaborator

@Lun4m Lun4m commented Jul 3, 2024

Fixes:

  • Add deploy role → moved to Add ansible files for deployment #33
  • Add security group for Obsinn during configuration
  • Add table partitions during configuration
  • Fix postgres data directory (closes Make Postgres use the correct partition for data storage #36)
  • Make style conform to ansible-lint
  • Figure out how to deal with changed_when and ignore_errors
  • Check if lard service should be stopped/restarted during switchover
  • Add automatic teardown of instances and volumes
  • Upgrade to postgres 17 and Ubuntu Noble
  • Add a way to handle ssh on teardown? (remove old VMs from known_hosts)
  • Figure out why lard_ingestion can't connect to postgres on the standby node
    "failed to lookup address information: Temporary failure in name resolution"
  • Add partitions for flags.kvdata (closes Partition flags.kvdata #58)

I think I want to merge this now, but there are still a couple issues (that I will open):

  1. For the last point the problem is that we can't connect to stinfosys, because the standby is not routed through the ipalias interface, therefore it drops most of the external connections. Probably we want to have two floating IPs and switch them if the primary goes down
  2. For the deploy, switchover, and failover roles we need to specify both the primary and the standby, which is bothersome and prone to error. This could be avoided by having a first tasks checking that the attached ip alias is the correct one (or not, for the replica(s)). Or check with repmgr like I did for thebigip.
  3. The failover playbook probably requires more testing, especially now that we have the ingestor running.

Edit: dropped kdvh and kvalobs labels, they should be part of the migration_fixes branch

@Lun4m Lun4m linked an issue Jul 8, 2024 that may be closed by this pull request
@Lun4m Lun4m force-pushed the deploy_lard branch 3 times, most recently from ef5290b to e906d07 Compare July 12, 2024 14:30
@Lun4m Lun4m changed the title Add Ansible files for deployment Add missing configuration options and fix ansible lint errors Oct 10, 2024
@Lun4m Lun4m removed a link to an issue Oct 10, 2024
@Lun4m Lun4m force-pushed the deploy_lard branch 3 times, most recently from f9e515b to aa9d7ff Compare January 23, 2025 13:04
@Lun4m Lun4m requested a review from intarga January 31, 2025 19:51
@Lun4m Lun4m marked this pull request as ready for review January 31, 2025 19:51
@Lun4m Lun4m force-pushed the deploy_lard branch 4 times, most recently from 29e8fc1 to 3d719f3 Compare February 5, 2025 10:40
tasks:
- name: Build
ansible.builtin.command:
chdir: ..
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is a bit of a hack, it expects that we are inside the ansible directory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth enforcing this in CI?

Comment on lines 3 to 4
powerline-status
powerline-gitstatus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not introduced in this PR, but this seems like an odd dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition flags.kvdata Make Postgres use the correct partition for data storage
2 participants