-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing configuration options and fix ansible lint errors #22
base: trunk
Are you sure you want to change the base?
Conversation
ef5290b
to
e906d07
Compare
f9e515b
to
aa9d7ff
Compare
29e8fc1
to
3d719f3
Compare
tasks: | ||
- name: Build | ||
ansible.builtin.command: | ||
chdir: .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is a bit of a hack, it expects that we are inside the ansible
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps worth enforcing this in CI?
powerline-status | ||
powerline-gitstatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not introduced in this PR, but this seems like an odd dependency?
Fixes:
changed_when
andignore_errors
known_hosts
)lard_ingestion
can't connect to postgres on the standby node"failed to lookup address information: Temporary failure in name resolution"
flags.kvdata
(closes Partition flags.kvdata #58)I think I want to merge this now, but there are still a couple issues (that I will open):
deploy
,switchover
, andfailover
roles we need to specify both the primary and the standby, which is bothersome and prone to error. This could be avoided by having a first tasks checking that the attached ip alias is the correct one (or not, for the replica(s)). Or check with repmgr like I did for thebigip
.Edit: dropped kdvh and kvalobs labels, they should be part of the
migration_fixes
branch