Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy from pyproj, as it breaks publishing to pypi #18

Open
havardhhaugen opened this issue Jan 30, 2025 · 4 comments
Open

Remove legacy from pyproj, as it breaks publishing to pypi #18

havardhhaugen opened this issue Jan 30, 2025 · 4 comments
Assignees
@tnipen @einrone

Comments

@havardhhaugen
Copy link
Contributor

No description provided.

@ways ways changed the title Fix pyproj legacy Remove legacy from pyproj, as it breaks publishing to pypi Jan 30, 2025
@ways
Copy link
Contributor

ways commented Feb 11, 2025

Wasn't this fixed by #23?

@ways
Copy link
Contributor

ways commented Feb 11, 2025

Wasn't this fixed by #23?

No, I see we still have legacy, https://github.com/metno/bris-inference/blob/main/bris/model.py#L41

@havardhhaugen
Copy link
Contributor Author

Wasn't this fixed by #23?

#23 should remove any legacy dependencies from dataset/datamodule, but I think it still exists in model, maybe @einrone can look into this?

@einrone
Copy link
Contributor

einrone commented Feb 11, 2025

I can take a look and fix it😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnipen tnipen

@einrone einrone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ways @tnipen @einrone @havardhhaugen