Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint project #13

Open
ways opened this issue Jan 29, 2025 · 1 comment
Open

Lint project #13

ways opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels

Comments

@ways
Copy link
Contributor

ways commented Jan 29, 2025

Using results from ruff and prospector.

$ tox -e ruffcheck
...
bris/__init__.py:10:1: E402 Module level import not at top of file
   |
10 | from . import callbacks
   | ^^^^^^^^^^^^^^^^^^^^^^^ E402
11 | from . import outputs
12 | from . import sources
...
$ tox -e prospector
...
bris/callbacks.py
  Line: 10
    pylint: import-error / Unable to import 'anemoi.utils.config'
  Line: 62
    pylint: arguments-renamed / Parameter 'filepath' has been renamed to 'lightning_checkpoint_filepath' in overriding 'NewModelCheckpoint._save_checkpoint' method (col 4)
  Line: 70
    pylint: protected-access / Access to a protected member _hparams of a client class (col 12)
...
@ways ways self-assigned this Jan 30, 2025
@ways
Copy link
Contributor Author

ways commented Jan 30, 2025

Har startet på dette med https://github.com/metno/bris-inference/compare/issue13?expand=1

Er det slikt du ønsker jeg skal fikse, eller skaper det for mye støy for andre utviklere? @tnipen

@ways ways added the stalled label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant