Merge pull request #44 from metagit-ai/zloeber/fix_broke_release

fix: broken release loop

Author: zloeber

.github/workflows/release.yaml

@@ -8,7 +8,7 @@ env:
   PROJECT_NAME: metagit-cli
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 permissions:
@@ -93,18 +93,4 @@ jobs:
       - name: Publish
         uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # v1.14.0
 
-  create-release:
-    name: Create GitHub Release
-    permissions:
-      contents: write
-    runs-on: ubuntu-latest
-    needs: publish-to-pypi
-    if: github.ref_type == 'tag'
-    steps:
-      - name: Create Release
-        uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0
-        with:
-          files: dist/*
-          make_latest: true
-          generate_release_notes: true
 

.github/workflows/semantic-release.yaml

@@ -5,6 +5,8 @@ on:
   push:
     branches:
       - main
+    paths-ignore:
+      - CHANGELOG.md
   workflow_dispatch:
 
 env:
@@ -84,47 +86,53 @@ jobs:
           MINOR=${MINOR:-0}
           PATCH=${PATCH:-0}
 
+          SHOULD_RELEASE=false
           if [[ $MAJOR_BUMP -eq 1 ]]; then
             MAJOR=$((MAJOR + 1))
             MINOR=0
             PATCH=0
+            SHOULD_RELEASE=true
           elif [[ $MINOR_BUMP -eq 1 ]]; then
             MINOR=$((MINOR + 1))
             PATCH=0
-          elif [[ $PATCH_BUMP -eq 1 ]] || git rev-parse "${{ steps.prev_tag.outputs.tag }}" >/dev/null 2>&1 && [[ "$PREV_TAG" != "0.0.0" ]]; then
+            SHOULD_RELEASE=true
+          elif [[ $PATCH_BUMP -eq 1 ]]; then
             PATCH=$((PATCH + 1))
-          else
-            if [[ "$PREV_TAG" == "0.0.0" ]] && [[ $PATCH_BUMP -eq 0 ]] && [[ $MINOR_BUMP -eq 0 ]] && [[ $MAJOR_BUMP -eq 0 ]]; then
-              PATCH=1
-            fi
+            SHOULD_RELEASE=true
           fi
 
           NEW_VERSION="$MAJOR.$MINOR.$PATCH"
           echo "new_version=$NEW_VERSION" >> $GITHUB_OUTPUT
+          echo "should_release=$SHOULD_RELEASE" >> $GITHUB_OUTPUT
           echo "New version: $NEW_VERSION"
+          echo "Should release: $SHOULD_RELEASE"
 
       - name: Check if tag already exists
         id: check_tag
+        if: steps.version.outputs.should_release == 'true'
         run: |
-          if git rev-parse "refs/tags/${{ steps.version.outputs.new_version }}" >/dev/null 2>&1; then
+          RELEASE_TAG="v${{ steps.version.outputs.new_version }}"
+          echo "release_tag=$RELEASE_TAG" >> $GITHUB_OUTPUT
+          if git rev-parse "refs/tags/$RELEASE_TAG" >/dev/null 2>&1; then
             echo "tag_exists=true" >> $GITHUB_OUTPUT
-            echo "Tag ${{ steps.version.outputs.new_version }} already exists"
+            echo "Tag $RELEASE_TAG already exists"
           else
             echo "tag_exists=false" >> $GITHUB_OUTPUT
           fi
 
       - name: Install uv
-        if: steps.check_tag.outputs.tag_exists == 'false'
+        if: steps.version.outputs.should_release == 'true' && steps.check_tag.outputs.tag_exists == 'false'
         run: |
           curl -LsSf https://astral.sh/uv/install.sh | sh
           echo "$HOME/.local/bin" >> $GITHUB_PATH
 
       - name: Promote changelog and write release notes
-        if: steps.check_tag.outputs.tag_exists == 'false'
+        if: steps.version.outputs.should_release == 'true' && steps.check_tag.outputs.tag_exists == 'false'
         id: changelog
         run: |
           PREV_TAG=${{ steps.prev_tag.outputs.tag }}
           NEW_VERSION="${{ steps.version.outputs.new_version }}"
+          NEW_TAG="${{ steps.check_tag.outputs.release_tag }}"
           RANGE=""
           if git rev-parse "$PREV_TAG" >/dev/null 2>&1; then
             RANGE="$PREV_TAG..HEAD"
@@ -139,33 +147,33 @@ jobs:
 
           {
             echo ""
-            echo "**Full Changelog**: https://github.com/${{ github.repository }}/compare/${PREV_TAG}...${NEW_VERSION}"
+            echo "**Full Changelog**: https://github.com/${{ github.repository }}/compare/${PREV_TAG}...${NEW_TAG}"
           } >> /tmp/release_body.md
 
       - name: Commit promoted changelog
-        if: steps.check_tag.outputs.tag_exists == 'false'
+        if: steps.version.outputs.should_release == 'true' && steps.check_tag.outputs.tag_exists == 'false'
         run: |
           git add CHANGELOG.md
           if git diff --cached --quiet; then
             echo "No changelog promotion changes to commit"
           else
-            git commit -m "chore: promote CHANGELOG for ${{ steps.version.outputs.new_version }}"
+            git commit -m "chore: promote CHANGELOG for ${{ steps.check_tag.outputs.release_tag }}"
             git push origin main
           fi
 
       - name: Create and push tag
-        if: steps.check_tag.outputs.tag_exists == 'false'
+        if: steps.version.outputs.should_release == 'true' && steps.check_tag.outputs.tag_exists == 'false'
         run: |
-          git tag -a "${{ steps.version.outputs.new_version }}" -m "Release ${{ steps.version.outputs.new_version }}"
-          git push origin "${{ steps.version.outputs.new_version }}"
-          echo "Created and pushed tag: ${{ steps.version.outputs.new_version }}"
+          git tag -a "${{ steps.check_tag.outputs.release_tag }}" -m "Release ${{ steps.check_tag.outputs.release_tag }}"
+          git push origin "${{ steps.check_tag.outputs.release_tag }}"
+          echo "Created and pushed tag: ${{ steps.check_tag.outputs.release_tag }}"
 
       - name: Create GitHub Release
-        if: steps.check_tag.outputs.tag_exists == 'false'
+        if: steps.version.outputs.should_release == 'true' && steps.check_tag.outputs.tag_exists == 'false'
         uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0
         with:
-          tag_name: ${{ steps.version.outputs.new_version }}
-          name: Release ${{ steps.version.outputs.new_version }}
+          tag_name: ${{ steps.check_tag.outputs.release_tag }}
+          name: Release ${{ steps.check_tag.outputs.release_tag }}
           body_path: /tmp/release_body.md
           draft: false
           prerelease: false
@@ -174,4 +182,6 @@ jobs:
         run: |
           echo "Previous tag: ${{ steps.prev_tag.outputs.tag }}"
           echo "New version: ${{ steps.version.outputs.new_version }}"
+          echo "Should release: ${{ steps.version.outputs.should_release }}"
+          echo "Release tag: ${{ steps.check_tag.outputs.release_tag }}"
           echo "Tag exists: ${{ steps.check_tag.outputs.tag_exists }}"

docs/development.md

@@ -87,7 +87,9 @@ GitHub org/user listing is flat (no nested subgroups). GitLab groups honor `--re
 `.github/workflows/semantic-release.yaml` runs on merges to `main` and uses conventional commit prefixes to compute the next version.
 
 - Promotes `## Unreleased` into a dated version section in `CHANGELOG.md`, commits to `main`, then tags.
+- Tags created by the workflow use the canonical `vX.Y.Z` format.
 - GitHub Release notes use the promoted changelog body (commit-log fallback only when `Unreleased` is empty).
+- Changelog-only commits do not retrigger semantic release, and no tag is created when there are no releasable `fix:`, `feat:`, or breaking-change commits since the previous tag.
 - Release automation is deterministic (no LLM). GitHub Copilot AI credits are not a free pipeline for custom workflows; they meter Copilot Chat/agents/review features instead.
 
 - `fix:` -> patch release (`X.Y.Z+1`) **default for most updates**