Skip to content

feat: added a dynamic smart contract(Price Feed) - #152

Open
aviral727 wants to merge 2 commits into
metafy-social:masterfrom
aviral727:master
Open

feat: added a dynamic smart contract(Price Feed)#152
aviral727 wants to merge 2 commits into
metafy-social:masterfrom
aviral727:master

Conversation

@aviral727

@aviral727 aviral727 commented Oct 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Description

Created a smart contract which uses an oracle(chainlink price feed) for getting real time price of eth/usd

Fixes #9

Dependencies

chainlink contracts v0.8

Future Improvements

Further the contract can be made more intuitive and optimizations can be done

Mentions

NA

Screenshots of relevant screens

image

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • [] My changes are breaking another fix/feature of the project
  • [] I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR

@github-actions

github-actions Bot commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening your first pull request in our repository, one of our maintainers will get in touch with you soon.

DO NOT FORGET TO ADD METAMASK WALLET ADDRESS IN THE AUTH FORM
We at Metafy have some special rewards and swags for the top contributors in general repos and every contributor in web3 repos
For being eligible for that, please authenticate yourself using this link:
https://metafy.social/signup

Rewards : T-shirts & NFT ( for blockchain contributions )

Best of luck on your Contributions
For further queries you can join our discord for support : https://discord.gg/W6PmEjjQsA

@github-actions

github-actions Bot commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

PR is not linked to any issue, please make the corresponding changes in the body.

@aviral727 aviral727 mentioned this pull request Oct 26, 2022
Open
@github-actions github-actions Bot added PR:Ready-to-Review hacktoberfest-accepted Hacktoberfest Accepted Pull Requests and removed PR:No-Issue labels Oct 26, 2022
@bartick

bartick commented Oct 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Not quiet sure how is this dynamic. Would have preferred if you are sending the price from the connected app.
Please explain your solution. Also please remove your hardcoded contract address and add a comment there

@advaita-saha please look into it

@aviral727

aviral727 commented Oct 30, 2022

Copy link
Copy Markdown
Author

@bartick I thought I just had to get data from an oracle for a dynamic contract. I may have misunderstood, any suggestions how I can rectify it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sadityakumar9211 sadityakumar9211 sadityakumar9211 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted Hacktoberfest Accepted Pull Requests PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dynamic smart contract

3 participants

@aviral727 @bartick @sadityakumar9211