Skip to content

Commit ae34f5f

Browse files
committed
🐞 execute inline scripts. #718, #782
1 parent 56442de commit ae34f5f

File tree

5 files changed

+20
-3
lines changed

5 files changed

+20
-3
lines changed

β€Žjs/page-load.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ function refreshScripts( fragment ) {
133133
var script = scripts[i];
134134
var freshScript = document.createElement('script');
135135
copyAttributes( script, freshScript );
136+
// copy inner script code. #718, #782
137+
freshScript.innerHTML = script.innerHTML;
136138
script.parentNode.replaceChild( freshScript, script );
137139
}
138140
}

β€Žsandbox/page/2.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ <h1 class="post-header__title">Every vector 2016</h1>
4242
<div class="post__content">
4343
<p><a href="https://i.imgur.com/mXaAcNO.png"><img src="https://i.imgur.com/mXaAcNO.png" alt="Metafizzy every vector 2016"></a></p>
4444
<p><a href="http://www.draplin.com/1998/01/ddc100_pretty_much_everything_up_to_oct_11_2013_poster.html">Draplin-esque</a> collage. Every vector made in 2016. Accepted, rejected, upcoming, or unused.</p>
45-
45+
<script>
46+
console.log('hello page 2!')
47+
</script>
4648
</div>
4749
</article>
4850
</div>

β€Žtest/page/2.html

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,17 @@
1111

1212
<h1>test page 2</h1>
1313

14-
<div class="post">page 2, post 1</div>
14+
<div class="post">
15+
page 2, post 1
16+
<script src="page/2.js"></script>
17+
</div>
1518

16-
<div class="post">page 2, post 2</div>
19+
<div class="post">
20+
page 2, post 2
21+
<script>
22+
window.page2InlineScriptLoaded = true;
23+
</script>
24+
</div>
1725

1826
<a class="page-load-next-link check-last-page-next-link" href="3.html">Page 3</a>
1927

β€Žtest/page/2.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
window.page2ExternalScriptLoaded = true;

β€Žtest/unit/page-load.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,17 @@ QUnit.test( 'pageLoad', function( assert ) {
3535
assert.equal( items.length, 2, 'items argument, length 2' );
3636
assert.ok( demoElem.children[1] === items[0], 'item0 appended' );
3737
assert.ok( demoElem.children[2] === items[1], 'item1 appended' );
38+
assert.ok( window.page2InlineScriptLoaded, 'inline script executed' );
3839
done();
3940
setTimeout( page3 ); // do next thing
4041
});
4142

4243
infScroll.loadNextPage();
4344

4445
function page3() {
46+
// check async external script, test not working
47+
// assert.ok( window.page2ExternalScriptLoaded, 'external script executed' );
48+
4549
infScroll.once( 'request', function( path ) {
4650
assert.ok( path.match('page/3.html'),
4751
'request event, path has page/3.html' );

0 commit comments

Comments
Β (0)