fixes

Author: alxnddr

CLAUDE.md

@@ -126,6 +126,13 @@ Adding a new field to `.bootstrap.json`:
 
 - Update the `Bootstrap` schema in `tests/e2e/bootstrap-data.ts`. The writer in `setup/bootstrap.ts` consumes the same schema for its parameter type — drift is mechanically prevented.
 
+Running e2e — the suite is slow (~3–5 minutes for a full run, ~hundreds of ms to seconds per test):
+
+- **Plan for failures on the first run.** Capture the full output end-to-end the first time so every failure is in hand before deciding next steps. Pipe to a file when the buffer is unreliable: `bun run test:e2e 2>&1 | tee /tmp/e2e.log`. Vitest's per-file failure summary at the end is the authoritative list — read it before rerunning. Rerunning the full suite "to see what failed" is a 3-minute round-trip; don't do it.
+- **Iterate on one file.** During development, scope to the file under change: `bun run test:e2e tests/e2e/<noun>.e2e.test.ts` (seconds, not minutes). Run the full suite only as the closing pre-merge check, not during back-and-forth.
+- **The stack persists.** `e2e:up` is idempotent and the bootstrap reuses `.bootstrap.json` when the stored key still authenticates, so iteration cost is dominated by test execution, not setup. Don't `e2e:down` between iterations.
+- **Bail-by-default is off.** Vitest runs all e2e files even after a failure, on purpose — the full failure inventory is more valuable than fast-fail when each rerun costs minutes. Don't pass `--bail=1` unless you genuinely want to abort early; you'll lose signal you'd have to rerun to recover.
+
 ## Don't
 
 - Add a color library or any colored output.

README.md

@@ -1202,18 +1202,18 @@ By default `start` returns once the bundle has been consumed by the child (`stat
 
 When `--repo <host-path>` is passed, the CLI bind-mounts the host directory at `/mnt/repo` inside the container and injects three settings into the workspace's `config.yml` so the child boots already wired to the repo: `remote-sync-url=file:///mnt/repo`, `remote-sync-branch=<branch>` (defaults to the current branch of the host repo, read via `git -C <path> symbolic-ref --short HEAD`; override with `--repo-branch`), and `remote-sync-type=<mode>` (defaults to `read-write`; override with `--repo-mode read-only`, which also makes the bind mount read-only). The bind mount is set at container-create time only — to add or change it after the fact, run `start --force` again with the new flags. The host path must be an existing directory; the CLI does not create or `git init` it for you.
 
-| Flag                   | Description                                                                                                                        |
-| ---------------------- | ---------------------------------------------------------------------------------------------------------------------------------- |
-| `--port <n>`           | Host port (default: 3000; auto-shifts up to 100 ports if taken).                                                                   |
-| `--image <ref>`        | Docker image (default: `metabase/metabase-dev:feature-workspaces-v2`).                                                             |
-| `--wait`               | Block until `/api/health` is ready. Default: return as soon as consumed.                                                           |
+| Flag                   | Description                                                                                                                                                                              |
+| ---------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| `--port <n>`           | Host port (default: 3000; auto-shifts up to 100 ports if taken).                                                                                                                         |
+| `--image <ref>`        | Docker image (default: `metabase/metabase-dev:feature-workspaces-v2`).                                                                                                                   |
+| `--wait`               | Block until `/api/health` is ready. Default: return as soon as consumed.                                                                                                                 |
 | `--timeout <ms>`       | Per-phase readiness deadline (default: 240000). Covers post-create config consumption, (with `--wait`) the `/api/health` probe, and (with `--metadata`) the metadata-import status poll. |
-| `--no-pull`            | Skip `docker pull` (useful if the image is already present).                                                                       |
-| `--no-metadata`        | Skip the warehouse metadata export.                                                                                                |
-| `--force`              | If a container for this workspace already exists, remove it before starting.                                                       |
-| `--repo <host-path>`   | Bind-mount a host directory at `/mnt/repo` and set `remote-sync-url=file:///mnt/repo` in `config.yml`.                             |
-| `--repo-branch <name>` | `remote-sync-branch` value (default: current branch of the host repo).                                                             |
-| `--repo-mode <mode>`   | `remote-sync-type`: `read-write` (default) or `read-only`. Read-only also makes the bind mount read-only.                          |
+| `--no-pull`            | Skip `docker pull` (useful if the image is already present).                                                                                                                             |
+| `--no-metadata`        | Skip the warehouse metadata export.                                                                                                                                                      |
+| `--force`              | If a container for this workspace already exists, remove it before starting.                                                                                                             |
+| `--repo <host-path>`   | Bind-mount a host directory at `/mnt/repo` and set `remote-sync-url=file:///mnt/repo` in `config.yml`.                                                                                   |
+| `--repo-branch <name>` | `remote-sync-branch` value (default: current branch of the host repo).                                                                                                                   |
+| `--repo-mode <mode>`   | `remote-sync-type`: `read-write` (default) or `read-only`. Read-only also makes the bind mount read-only.                                                                                |
 
 ### `metabase workspace stop <id>`
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@metabase/cli",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Metabase CLI",
   "license": "AGPL-3.0",
   "repository": {

src/commands/auth/login.ts

@@ -1,9 +1,9 @@
 import { z } from "zod";
 
 import { clearRejection, recordRejection } from "../../core/auth/rejection";
-import { writeProfile } from "../../core/auth/storage";
+import { DEFAULT_PROFILE, writeProfile } from "../../core/auth/storage";
 import { verifyCredentials } from "../../core/auth/verify";
-import { readEnvCredentials, resolveProfileName } from "../../core/config";
+import { explicitProfileName, readEnvCredentials } from "../../core/config";
 import { ConfigError, errorMessage } from "../../core/errors";
 import { normalizeUrl } from "../../core/url";
 import type { ResourceView } from "../../domain/view";
@@ -26,9 +26,13 @@ const loginView: ResourceView<LoginResultJson> = {
   compactPick: LoginResult,
   tableColumns: [
     { key: "profile", label: "Profile" },
-    { key: "url", label: "URL" },
-    { key: "authenticated", label: "Authenticated" },
-    { key: "email", label: "Email" },
+    { key: "url", label: "Metabase URL" },
+    {
+      key: "authenticated",
+      label: "Status",
+      format: (value) => (value === true ? "credentials verified" : "saved without verification"),
+    },
+    { key: "email", label: "Logged in as" },
   ],
 };
 
@@ -51,7 +55,7 @@ export default defineMetabaseCommand({
     "metabase auth login --profile staging --url https://staging.example.com",
   ],
   async run({ args, ctx }) {
-    const profileName = resolveProfileName(args.profile);
+    const profileName = await resolveLoginProfile(args.profile);
     const env = readEnvCredentials();
 
     if (args.apiKey) {
@@ -87,6 +91,22 @@ export default defineMetabaseCommand({
   },
 });
 
+async function resolveLoginProfile(flagProfile: string | undefined): Promise<string> {
+  const explicit = explicitProfileName(flagProfile);
+  if (explicit !== null) {
+    return explicit;
+  }
+  if (!process.stdin.isTTY) {
+    return DEFAULT_PROFILE;
+  }
+  return promptText({
+    message: "Profile name",
+    placeholder: DEFAULT_PROFILE,
+    initialValue: DEFAULT_PROFILE,
+    validate: (input) => (input ? undefined : "Profile name is required"),
+  });
+}
+
 async function resolveUrl(flagUrl: string | undefined, envUrl: string | null): Promise<string> {
   if (flagUrl) {
     return normalizeUrl(flagUrl);

src/core/config.test.ts

@@ -13,7 +13,7 @@ vi.mock("@napi-rs/keyring", async () => {
 import { recordRejection } from "./auth/rejection";
 import { writeProfile } from "./auth/storage";
 import { setupTempConfigHome, type TempConfigHome } from "./auth/temp-config-home";
-import { resolveConfig, resolveProfileName } from "./config";
+import { explicitProfileName, resolveConfig, resolveProfileName } from "./config";
 import { ConfigError } from "./errors";
 
 describe("resolveConfig", () => {
@@ -207,3 +207,29 @@ describe("resolveProfileName", () => {
     expect(resolveProfileName(undefined)).toBe("default");
   });
 });
+
+describe("explicitProfileName", () => {
+  const originalEnv = { ...process.env };
+
+  beforeEach(() => {
+    delete process.env["METABASE_PROFILE"];
+  });
+
+  afterEach(() => {
+    process.env = { ...originalEnv };
+  });
+
+  it("returns the flag value when provided", () => {
+    process.env["METABASE_PROFILE"] = "env-profile";
+    expect(explicitProfileName("flag-profile")).toBe("flag-profile");
+  });
+
+  it("returns METABASE_PROFILE when no flag", () => {
+    process.env["METABASE_PROFILE"] = "env-profile";
+    expect(explicitProfileName(undefined)).toBe("env-profile");
+  });
+
+  it("returns null when neither flag nor env is set", () => {
+    expect(explicitProfileName(undefined)).toBeNull();
+  });
+});

src/core/config.ts

@@ -38,7 +38,11 @@ interface FieldResolution {
 }
 
 export function resolveProfileName(profileFlag: string | undefined): string {
-  return profileFlag || process.env[ENV_PROFILE] || DEFAULT_PROFILE;
+  return explicitProfileName(profileFlag) ?? DEFAULT_PROFILE;
+}
+
+export function explicitProfileName(profileFlag: string | undefined): string | null {
+  return profileFlag || process.env[ENV_PROFILE] || null;
 }
 
 export function readEnvCredentials(): EnvCredentials {

tests/e2e/auth.e2e.test.ts

@@ -217,6 +217,55 @@ describe("auth e2e", () => {
     });
   });
 
+  it("login routes through METABASE_PROFILE when no --profile flag is passed", async () => {
+    const configHome = await makeIsolatedConfigHome();
+
+    const login = await runCli({
+      args: [
+        "auth",
+        "login",
+        "--url",
+        bootstrap.baseUrl,
+        "--api-key",
+        bootstrap.adminApiKey,
+        "--json",
+      ],
+      configHome,
+      env: { METABASE_PROFILE: "env_routed" },
+    });
+
+    expect(login.exitCode, login.stderr).toBe(0);
+    expect(parseJson(login.stdout, LoginResult)).toEqual({
+      profile: "env_routed",
+      url: bootstrap.baseUrl,
+      authenticated: true,
+      email: bootstrap.adminApiKeyEmail,
+    });
+
+    const defaultStatus = await runCli({
+      args: ["auth", "status", "--json"],
+      configHome,
+    });
+    expect(defaultStatus.exitCode, defaultStatus.stderr).toBe(0);
+    expect(parseJson(defaultStatus.stdout, AuthStatus)).toEqual({
+      profile: "default",
+      present: false,
+      url: null,
+    });
+
+    const envStatus = await runCli({
+      args: ["auth", "status", "--json"],
+      configHome,
+      env: { METABASE_PROFILE: "env_routed" },
+    });
+    expect(envStatus.exitCode, envStatus.stderr).toBe(0);
+    expect(parseJson(envStatus.stdout, AuthStatus)).toEqual({
+      profile: "env_routed",
+      present: true,
+      url: bootstrap.baseUrl,
+    });
+  });
+
   it("logout proceeds without --yes when stdin is not a TTY (non-interactive auto-confirm)", async () => {
     const configHome = await makeIsolatedConfigHome();