Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter logo need to be Updated to X #1442

Closed
saurabh100ni opened this issue Oct 2, 2023 · 17 comments · Fixed by #1465
Closed

Twitter logo need to be Updated to X #1442

saurabh100ni opened this issue Oct 2, 2023 · 17 comments · Fixed by #1465
Assignees
Labels
area/website good first issue Good for newcomers hacktoberfest Happy contributing! help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@saurabh100ni
Copy link

Description

Twitter logo in the last section of meshery.io/community need to be updated to X


Contributor Guides and Resources

@saurabh100ni saurabh100ni added kind/enhancement New feature or request area/website labels Oct 2, 2023
@welcome
Copy link

welcome bot commented Oct 2, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.

@saurabh100ni saurabh100ni added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Happy contributing! labels Oct 2, 2023
@infiniteltd
Copy link

I mean would love to work on this issue.

@saurabh100ni
Copy link
Author

Go on @infiniteltd 😎🚀

@infiniteltd
Copy link

Thanks boss.

@adi-ray
Copy link

adi-ray commented Oct 3, 2023

@saurabh100ni could you please assign this issue to me . I have made the required changes .

@saurabh100ni
Copy link
Author

I see @adi-ray, @infiniteltd any updates?
PS: @adi-ray it's recommended to work on issue after assignment ^ ^

@infiniteltd
Copy link

I have also made the changes. Creating a Pr soon.

@saurabh100ni
Copy link
Author

@adi-ray @infiniteltd ,
Let's go with @infiniteltd 's PR as he was assigned to the issue.

I'm sure @adi-ray there are many open issues you can contribute to ^ ^

@adi-ray
Copy link

adi-ray commented Oct 5, 2023

@saurabh100ni There is no PR raised, so it would be great if i continue with this issue, as I had already made the required changes.
Thanking You.

@sandramsc
Copy link
Member

sandramsc commented Oct 8, 2023

@saurabh100ni There is no PR raised, so it would be great if i continue with this issue, as I had already made the required changes. Thanking You.

@adi-ray thank you for your enthusiasm, as @saurabh100ni has already tried to emphasize, you need to request for an issue to be assigned to you first before opening PR (this reduces the risk of wasting your time and effort as a result of the issue being rightfully assigned to someone else), i.e only after it is assigned to you then open the PR. If you haven't already, consider familiarizing yourself with the Contributing guidelines, particularly the section under "Finding an Issue to Work On". Let's focus on collaboration, not competition.

@hemantmm
Copy link
Contributor

Hi, @saurabh100ni could I work on this issue?

@abhijeetgauravm
Copy link

@infiniteltd updates here?

@sohamtembhurne
Copy link

Hi @abhijeetgauravm,
I think the PR here fixes the issue. Since its a small issue, I don't think it should take 2 weeks to fix it.

@adi-ray
Copy link

adi-ray commented Oct 17, 2023

@saurabh100ni could you please assign this issue to me . I have made the required changes .

@abhijeetgauravm

@abhijeetgauravm
Copy link

abhijeetgauravm commented Oct 17, 2023

@saurabh100ni could you please assign this issue to me . I have made the required changes .

@abhijeetgauravm

Hey @adi-ray, since there is already a PR open by @Himanshu1801 , you can help in reviewing the PR and @Himanshu1801, really appreciate your enthusiasm to contribute. However, please refrain from creating direct PRs without getting assigned first. Please do take the time to read the Contributing guidelines.

@HimanshuMahto
Copy link

hey can you assign me this work as a new to open source world it would be a great help to work on this.

@abhijeetgauravm
Copy link

Hey @adi-ray, since there is already a PR open by @Himanshu1801 , you can help in reviewing the PR

Hey @HimanshuMahto, since there is already a PR open by @Himanshu1801 , you can help in reviewing the PR. Here you'll find many good-first and help-wanted issues:
https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+org%3Alayer5io+org%3Ameshery+org%3Aservice-mesh-performance+org%3Aservice-mesh-patterns+label%3A%22help+wanted%22+

Feel free to check these out and comment to get assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website good first issue Good for newcomers hacktoberfest Happy contributing! help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
8 participants