You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CI only using golangci-lint to check the code. However, I found in some repo although the CI is passed, the go mod tidy still has issues. So, the project would not build or be failed to build. Like: meshery/meshkit#396
Desired Behavior
So, here.
We enable golangci-lint check the go mod status, also add -v to let it output more detail than before
golangci-lint should be triggered through Makefile
Current Behavior
The CI only using golangci-lint to check the code. However, I found in some repo although the CI is passed, the
go mod tidy
still has issues. So, the project would not build or be failed to build. Like: meshery/meshkit#396Desired Behavior
So, here.
golangci-lint
check the go mod status, also add -v to let it output more detail than beforego mod tidy
directly in CI bymake tidy
go test
also run though the MakefileImplementation
Acceptance Tests
Contributor Guides and Resources
The text was updated successfully, but these errors were encountered: