Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: The CI needs to be more solid #541

Closed
Aisuko opened this issue Oct 22, 2023 · 0 comments · Fixed by #540
Closed

[CI]: The CI needs to be more solid #541

Aisuko opened this issue Oct 22, 2023 · 0 comments · Fixed by #540
Labels
area/ci Continuous integration

Comments

@Aisuko
Copy link
Member

Aisuko commented Oct 22, 2023

Current Behavior

The CI only using golangci-lint to check the code. However, I found in some repo although the CI is passed, the go mod tidy still has issues. So, the project would not build or be failed to build. Like: meshery/meshkit#396

Desired Behavior

So, here.

  • We enable golangci-lint check the go mod status, also add -v to let it output more detail than before
  • golangci-lint should be triggered through Makefile
  • Check go mod tidy directly in CI by make tidy
  • go test also run though the Makefile

Implementation

Acceptance Tests


Contributor Guides and Resources

@Aisuko Aisuko added the area/ci Continuous integration label Oct 22, 2023
@Aisuko Aisuko changed the title [CI]: The CI needs more solid [CI]: The CI needs to be more solid Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant