chore: cleanup

Author: florianow

modules/azure/aks/backplane/README.md

@@ -1,4 +1,4 @@
-# AKS CLuster
+# AKS Cluster
 
 This documentation is intended as a reference documentation for cloud foundation or platform engineers using this module.
 
@@ -83,4 +83,4 @@ No modules.
 | <a name="output_role_definition_name"></a> [role\_definition\_name](#output\_role\_definition\_name) | The name of the role definition that enables deployment of the building block. |
 | <a name="output_scope"></a> [scope](#output\_scope) | The scope where the role definition and role assignments are applied. |
 | <a name="output_workload_identity_federation"></a> [workload\_identity\_federation](#output\_workload\_identity\_federation) | Information about the created workload identity federation credential. |
-<!-- END_TF_DOCS -->
+<!-- END_TF_DOCS -->

modules/azure/aks/backplane/outputs.tf

@@ -146,7 +146,7 @@ output "provider_tf" {
 
         client_id       = "${azuread_service_principal.buildingblock_deploy[0].client_id}"
         client_secret   = "${azuread_application_password.buildingblock_deploy[0].value}"
-        subscription_id = "<LANDING_ZONE_ID>"
+        subscription_id = "<SUBSCRIPTION_ID>"
         tenant_id       = "${data.azurerm_subscription.current.tenant_id}"
       }
 

modules/azure/aks/buildingblock/APP_TEAM_README.md

@@ -90,7 +90,7 @@ This building block is for application teams that need to deploy containerized a
 | `subnet_name` | Name of existing subnet to use. If `null`, creates new subnet. | No | `null` (creates new) |
 | `vnet_address_space` | Address space for new VNet. Only used when `vnet_name == null`. | No | `10.240.0.0/16` |
 | `subnet_address_prefix` | Address prefix for new subnet. Only used when `subnet_name == null`. | No | `10.240.0.0/20` |
-| `allow_gateway_transit_from_hub` | Allow gateway transit from hub for on-premises connectivity. | No | `true` |
+| `allow_gateway_transit_from_hub` | Allow gateway transit from hub for on-premises connectivity. | No | `false` |
 
 ### Hub Connectivity (for Private Clusters)
 

modules/azure/aks/buildingblock/README.md

@@ -197,7 +197,6 @@ module "aks" {
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
-| <a name="requirement_azuread"></a> [azuread](#requirement\_azuread) | ~> 3.4.0 |
 | <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | ~> 4.36.0 |
 | <a name="requirement_time"></a> [time](#requirement\_time) | ~> 0.11.1 |
 

modules/azure/aks/buildingblock/provider.tf

@@ -1,5 +1,3 @@
 provider "azurerm" {
   features {}
 }
-
-provider "azuread" {}

modules/azure/aks/buildingblock/versions.tf

@@ -8,11 +8,6 @@ terraform {
       configuration_aliases = [azurerm, azurerm.hub]
     }
 
-    azuread = {
-      source  = "hashicorp/azuread"
-      version = "~> 3.4.0"
-    }
-
     time = {
       source  = "hashicorp/time"
       version = "~> 0.11.1"

modules/azure/container-registry/backplane/outputs.tf

@@ -146,7 +146,7 @@ output "provider_tf" {
 
         client_id       = "${azuread_service_principal.buildingblock_deploy[0].client_id}"
         client_secret   = "${azuread_application_password.buildingblock_deploy[0].value}"
-        subscription_id = "<LANDING_ZONE_ID>"
+        subscription_id = "<SUBSCRIPTION_ID>"
         tenant_id       = "${data.azurerm_subscription.current.tenant_id}"
       }
 
@@ -175,7 +175,7 @@ output "provider_tf" {
 
         client_id       = "${azuread_service_principal.buildingblock_deploy[0].client_id}"
         use_oidc        = true
-        subscription_id = "<LANDING_ZONE_SUBSCRIPTION_ID>"
+        subscription_id = "<SUBSCRIPTION_ID>"
         tenant_id       = "${data.azurerm_subscription.current.tenant_id}"
       }