Skip to content

Commit 2008030

Browse files
authored
Merge pull request #83 from meshcloud/feature/updateSPNbb
update output to send null as string
2 parents 2d52fe7 + 785c6d1 commit 2008030

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

modules/azure/service-principal/buildingblock/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,8 @@ No modules.
251251
| <a name="output_application_object_id"></a> [application\_object\_id](#output\_application\_object\_id) | Object ID of the Entra ID application |
252252
| <a name="output_authentication_method"></a> [authentication\_method](#output\_authentication\_method) | Authentication method for the service principal |
253253
| <a name="output_azure_role"></a> [azure\_role](#output\_azure\_role) | Azure role assigned to the service principal |
254-
| <a name="output_client_secret"></a> [client\_secret](#output\_client\_secret) | Client secret for the service principal (null if create\_client\_secret is false) |
255-
| <a name="output_secret_expiration_date"></a> [secret\_expiration\_date](#output\_secret\_expiration\_date) | Date when the service principal secret will expire (null if create\_client\_secret is false) |
254+
| <a name="output_client_secret"></a> [client\_secret](#output\_client\_secret) | Client secret for the service principal ("null" if create\_client\_secret is false) |
255+
| <a name="output_secret_expiration_date"></a> [secret\_expiration\_date](#output\_secret\_expiration\_date) | Date when the service principal secret will expire ("null" if create\_client\_secret is false) |
256256
| <a name="output_service_principal_id"></a> [service\_principal\_id](#output\_service\_principal\_id) | Client ID of the service principal (same as application\_id) |
257257
| <a name="output_service_principal_object_id"></a> [service\_principal\_object\_id](#output\_service\_principal\_object\_id) | Object ID of the service principal |
258258
| <a name="output_subscription_id"></a> [subscription\_id](#output\_subscription\_id) | Azure Subscription ID where role assignment was created |

modules/azure/service-principal/buildingblock/outputs.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ output "service_principal_object_id" {
1919
}
2020

2121
output "client_secret" {
22-
description = "Client secret for the service principal (null if create_client_secret is false)"
23-
value = var.create_client_secret ? azuread_application_password.main[0].value : null
22+
description = "Client secret for the service principal (\"null\" if create_client_secret is false)"
23+
value = var.create_client_secret ? azuread_application_password.main[0].value : "null"
2424
sensitive = true
2525
}
2626

@@ -40,8 +40,8 @@ output "azure_role" {
4040
}
4141

4242
output "secret_expiration_date" {
43-
description = "Date when the service principal secret will expire (null if create_client_secret is false)"
44-
value = var.create_client_secret ? azuread_application_password.main[0].end_date : null
43+
description = "Date when the service principal secret will expire (\"null\" if create_client_secret is false)"
44+
value = var.create_client_secret ? azuread_application_password.main[0].end_date : "null"
4545
}
4646

4747
output "authentication_method" {

0 commit comments

Comments
 (0)