Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to prepend "0" for single digit hours so everything lines up #15

Closed
prurigro opened this issue Jan 10, 2025 · 6 comments · Fixed by #17
Closed

Suggestion to prepend "0" for single digit hours so everything lines up #15

prurigro opened this issue Jan 10, 2025 · 6 comments · Fixed by #17

Comments

@prurigro
Copy link

Currently if one timezone is <10h (eg: 6:00PM) and another is >=10h (eg: 12:30PM), the times don't line up. If <10h had a 0 prepended to the hours, everything should line up nicely.

Screenshot From 2025-01-10 14-45-13

@merschformann
Copy link
Owner

Damn, sorry for the oversight. I am on a 24 hours clock and didn't notice. Thanks for raising the issue! 🤗

Addressing it via #17.

@merschformann
Copy link
Owner

I only wonder which one it should be:

  1. 05:00AM
  2. 5:00AM

I don't have a strong opinion at all and will stick with your suggestion if noone wants to weigh in. ☺️

@prurigro
Copy link
Author

prurigro commented Jan 11, 2025

Oh true, I don't know why I didn't think of simply adding a blank character. I think that would technically more correct than the prepended zero for AM/PM :) Thanks for the speedy response- I love the tool!

@DannyBen
Copy link

Absolutely space instead of zero I think.

The tool is indeed quite useful - love how it remembers the command line options, very elegant and frictionless.

@merschformann
Copy link
Owner

Roger, roger. I adapted #17 and will make a release soon. Thanks for the input! 🤗

@merschformann
Copy link
Owner

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants