Skip to content

fix/mm2-1404-promotions-table-missing-searchparams #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
+5 −3
Merged

fix/mm2-1404-promotions-table-missing-searchparams #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/hooks/table/query/use-promotion-table-query.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,18 @@ export const usePromotionTableQuery = ({
pageSize = 20,
}: UsePromotionTableQueryProps) => {
const queryObject = useQueryParams(
["offset", "q", "created_at", "updated_at"],
["offset", "q", "created_at", "updated_at", "order"],
prefix
)

const { offset, q, created_at, updated_at } = queryObject
const { offset, q, created_at, updated_at, order } = queryObject

const searchParams: HttpTypes.AdminGetPromotionsParams = {
limit: pageSize,
created_at: created_at ? JSON.parse(created_at) : undefined,
updated_at: updated_at ? JSON.parse(updated_at) : undefined,
offset: offset ? Number(offset) : 0,
order,
q,
}

Expand Down
3 changes: 2 additions & 1 deletion ...routes/promotions/promotion-list/components/promotion-list-table/promotion-list-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const PAGE_SIZE = 20
export const PromotionListTable = () => {
const { t } = useTranslation()

const { raw } = usePromotionTableQuery({
const { searchParams, raw } = usePromotionTableQuery({
pageSize: PAGE_SIZE,
})
const {
Expand All @@ -33,6 +33,7 @@ export const PromotionListTable = () => {
error,
} = usePromotions({
fields: "+status",
...searchParams,
})

const promotions = data?.filter((item) => item !== null)
Expand Down