Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OASIS abort if too high RUNTIME value - Correction #32

Closed
alexis-barge opened this issue Oct 25, 2024 · 1 comment
Closed

OASIS abort if too high RUNTIME value - Correction #32

alexis-barge opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alexis-barge
Copy link
Collaborator

alexis-barge commented Oct 25, 2024

OASIS parser is limited to 8 digits numbers when reading exchanges frequencies.
If defining STATIC exchanges with RUNTIME bigger than 8 digits, OASIS will read truncated values. Leading to synchronicty errors.

For instance:

  • RUNTIME : 123456789
  • READ FREQUENCY : 12345678

Correction : raise an error from Eophis if STATIC frequency is too high. Error tells user to lower ITER*DT and run several segments instead , or not to use STATIC exchange, or to upgrade to at least v1.1.x.

preprod mode : check and raise error in namcouple._finalize --> -1 STATIC and RUNTIME known
prod mode : during make_and_check() --> RUNTIME known from read namcouple and STATIC are spotted for check

@alexis-barge alexis-barge added this to the Release_v1.0.1 milestone Oct 25, 2024
@alexis-barge alexis-barge added the bug Something isn't working label Oct 25, 2024
@alexis-barge alexis-barge changed the title OASIS abort if too high RUNTIME value OASIS abort if too high RUNTIME value - Correction Oct 25, 2024
alexis-barge added a commit that referenced this issue Oct 31, 2024
* increase version

* error messages if runtime too high

* unit tests for is_in and find_pos
@alexis-barge
Copy link
Collaborator Author

Done with #37

alexis-barge added a commit that referenced this issue Dec 6, 2024
* generalize arch dir lib

* add eophis container

* Workflows to build container images

* remove arm64 build

* generalize

* Eophis amd container (#31)

* add eophis container

* Workflows to build container amd64 image

* rm compiler flags

* cleaner make.gnu

* installation from container

* Update install.rst

* Solve issue #32 (#37)

* increase version

* error messages if runtime too high

* unit tests for is_in and find_pos

* clone release and not main

* Update apptainer_eophis.def

* replace fake earth by toy earth

* add tutorial material and documentation

* add reference to tutorial

* install matplotlib in apptainer

* fix wrong script name

* move tutorial in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant