Skip to content

Commit 28d0f54

Browse files
committed
chore: don't make file disappear after removal
1 parent fa146dc commit 28d0f54

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

packages/pluggableWidgets/file-uploader-web/src/components/FileEntry.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ function FileEntry(props: FileEntryProps): ReactElement {
8383
return (
8484
<div
8585
className={classNames("file-entry", {
86-
removed: props.fileStatus === "removedFile",
86+
removed: props.fileStatus === "removedFile" || props.fileStatus === "removedAfterError",
8787
invalid: props.fileStatus === "validationError"
8888
})}
8989
title={props.title}

packages/pluggableWidgets/file-uploader-web/src/components/UploadInfo.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export function UploadInfo({ status, error }: UploadInfoProps): ReactElement {
1515
case "done":
1616
return <span className={"upload-status success"}>{translations.get("uploadSuccessMessage")}</span>;
1717
case "uploadingError":
18+
case "removedAfterError":
1819
return <span className={"upload-status error"}>{translations.get("uploadFailureGenericMessage")}</span>;
1920
case "validationError":
2021
return <span className={"upload-status error"}>{error}</span>;

packages/pluggableWidgets/file-uploader-web/src/stores/FileStore.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export type FileStatus =
2121
| "uploading"
2222
| "done"
2323
| "uploadingError"
24+
| "removedAfterError"
2425
| "removedFile"
2526
| "validationError";
2627

@@ -64,7 +65,8 @@ export class FileStore {
6465
}
6566

6667
markMissing(): void {
67-
this.fileStatus = "missing";
68+
this.fileStatus = this.fileStatus === "uploadingError" ? "removedAfterError" : "missing";
69+
6870
this._mxObject = undefined;
6971
this._objectItem = undefined;
7072
}

0 commit comments

Comments
 (0)