From d9ace9f060bdea7ff396587756f42ac2a383b191 Mon Sep 17 00:00:00 2001 From: imilinovic Date: Fri, 25 Apr 2025 11:59:45 +0200 Subject: [PATCH 1/4] Documentation for snapshot perf --- pages/fundamentals/data-durability.mdx | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pages/fundamentals/data-durability.mdx b/pages/fundamentals/data-durability.mdx index eb7c08beb..1c8921892 100644 --- a/pages/fundamentals/data-durability.mdx +++ b/pages/fundamentals/data-durability.mdx @@ -114,6 +114,10 @@ Alternatively, you can make one directly by running the following query: CREATE SNAPSHOT; ``` + +If another snapshot is already being created or no commited writes to the database have been made since the last snapshot this query will fail with an error. + + By default, snapshot files are saved inside the `var/lib/memgraph/snapshots` directory. To query which snapshots currently exist in the data directory, execute: @@ -153,6 +157,12 @@ background thread will pause and no snapshots will be created as long as that mode is active. The job will continue with the last defined interval when the storage mode is changed to `IN_MEMORY_TRANSACTIONAL` storage mode. + +If during the periodic snapshot another snapshot is already being created or no commited writes +to the database have been made since the last snapshot this periodic snapshot will be skipped. +If the periodic snapshot is skipped it will be logged on INFO level. + + Snapshots and WAL files are presently not compatible between Memgraph versions. From 0037ba6f0b384a2efb9998d3ad8bbcc9d1683ba6 Mon Sep 17 00:00:00 2001 From: imilinovic Date: Fri, 25 Apr 2025 12:05:18 +0200 Subject: [PATCH 2/4] grammar --- pages/fundamentals/data-durability.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pages/fundamentals/data-durability.mdx b/pages/fundamentals/data-durability.mdx index 1c8921892..7977e52ab 100644 --- a/pages/fundamentals/data-durability.mdx +++ b/pages/fundamentals/data-durability.mdx @@ -115,7 +115,7 @@ CREATE SNAPSHOT; ``` -If another snapshot is already being created or no commited writes to the database have been made since the last snapshot this query will fail with an error. +If another snapshot is already being created or no committed writes to the database have been made since the last snapshot this query will fail with an error. By default, snapshot files are saved inside the `var/lib/memgraph/snapshots` directory. @@ -158,7 +158,7 @@ mode is active. The job will continue with the last defined interval when the storage mode is changed to `IN_MEMORY_TRANSACTIONAL` storage mode. -If during the periodic snapshot another snapshot is already being created or no commited writes +If during the periodic snapshot another snapshot is already being created or no committed writes to the database have been made since the last snapshot this periodic snapshot will be skipped. If the periodic snapshot is skipped it will be logged on INFO level. From bb5e7c0707d79246b2f67a57a9d0ee4967dc0bfb Mon Sep 17 00:00:00 2001 From: imilinovic Date: Fri, 25 Apr 2025 12:09:20 +0200 Subject: [PATCH 3/4] different wording --- pages/fundamentals/data-durability.mdx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pages/fundamentals/data-durability.mdx b/pages/fundamentals/data-durability.mdx index 7977e52ab..c6a5c97c7 100644 --- a/pages/fundamentals/data-durability.mdx +++ b/pages/fundamentals/data-durability.mdx @@ -158,8 +158,7 @@ mode is active. The job will continue with the last defined interval when the storage mode is changed to `IN_MEMORY_TRANSACTIONAL` storage mode. -If during the periodic snapshot another snapshot is already being created or no committed writes -to the database have been made since the last snapshot this periodic snapshot will be skipped. +The periodic snapshot will be skipped if another snapshot is in progress or no new writes have been committed since the last snapshot. If the periodic snapshot is skipped it will be logged on INFO level. From 078bb60269d9fa186769e485a1717030df844256 Mon Sep 17 00:00:00 2001 From: Ante Javor Date: Wed, 28 May 2025 10:50:30 +0200 Subject: [PATCH 4/4] Update pages/fundamentals/data-durability.mdx --- pages/fundamentals/data-durability.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/fundamentals/data-durability.mdx b/pages/fundamentals/data-durability.mdx index c6a5c97c7..a4e6e8be5 100644 --- a/pages/fundamentals/data-durability.mdx +++ b/pages/fundamentals/data-durability.mdx @@ -115,7 +115,7 @@ CREATE SNAPSHOT; ``` -If another snapshot is already being created or no committed writes to the database have been made since the last snapshot this query will fail with an error. +If another snapshot is already being created or no committed writes to the database have been made since the last snapshot, this query will fail with an error. By default, snapshot files are saved inside the `var/lib/memgraph/snapshots` directory.