missing some useful parameter

[bitchecker]

Hi,
in driver section I see that is possible to configure user for API and SSH but, IMHO, some parameters are missing.

I think that some hardened network configs should require two other parameters:

• api_port: if proxmox web-ui is behind some reverse proxy
• ssh_port: if non-standard ssh port is used or a bastion host is running in place

[IamLunchbox]

I suppose a pull request is most certainly welcome to make these requirements possible. Michael did check on mine quite fast, so it should not take too long to get it merged.

ssh_port maybe need to be templated here and the value should be - in my opinion - derived from a platform value.

api_port is currently implicitly 8006 - the community.general.proxmox_kvm documentation mentioned, that this value may be derived from the environment variable PROXMOX_PORT - so this could fit your needs in the meantime.
If you want to prepare a pull request, the option must be added to all api calls in create.yml and destroy.yml in src/molecule_proxmox/playbooks/.

[meffie]

Hmm, yes it seems we could add these to override the default ports. I try to avoid adding configuration unless someone actually needs it, but alternate port numbers seems ok.

[IamLunchbox]

#19 fixes this issue.

[meffie]

#19 fixes this issue.

Thank you. I will do a point release with this change then we can close this issue.