Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift uuid to 11+ #9769

Open
jkuester opened this issue Jan 31, 2025 · 0 comments
Open

Uplift uuid to 11+ #9769

jkuester opened this issue Jan 31, 2025 · 0 comments
Labels
Dependencies Update the project's dependencies/libraries Type: Technical issue Improve something that users won't notice

Comments

@jkuester
Copy link
Contributor

Describe the issue
As of uuid 11.0.0 the browserfy-admin.sh script will no longer complete successfully.

You get the error:

browserify-admin: running browserify on main.js
Error: Parsing file /var/home/jlkuester7/git/cht-core/node_modules/uuid/dist/cjs-browser/v1.js: Unexpected token (28:18)
    at Deps.parseDeps (/var/home/jlkuester7/git/cht-core/node_modules/module-deps/index.js:519:15)
    at getDeps (/var/home/jlkuester7/git/cht-core/node_modules/module-deps/index.js:447:44)
    at /var/home/jlkuester7/git/cht-core/node_modules/module-deps/index.js:430:38
    at ConcatStream.<anonymous> (/var/home/jlkuester7/git/cht-core/node_modules/concat-stream/index.js:37:43)
    at ConcatStream.emit (node:events:536:35)
    at finishMaybe (/var/home/jlkuester7/git/cht-core/node_modules/readable-stream/lib/_stream_writable.js:630:14)
    at endWritable (/var/home/jlkuester7/git/cht-core/node_modules/readable-stream/lib/_stream_writable.js:638:3)
    at Writable.end (/var/home/jlkuester7/git/cht-core/node_modules/readable-stream/lib/_stream_writable.js:594:22)
    at DuplexWrapper.onend (/var/home/jlkuester7/git/cht-core/node_modules/readable-stream/lib/_stream_readable.js:577:10)
    at Object.onceWrapper (node:events:638:28)

Process finished with exit code 1

I tried pinning to "uuid": "10.0.0" in admin/package.json, but that did not help (even though running with that version in the root package.json work fine).

The line in the uuid/dist/cjs-browser/v1.js file that seems to be causing the issue is doing some nullish coalescing assignment. My theory is that something in browserfy (or more likely the ancient browserify-ngannotate) is not current enough to recognize that syntax (though it is far from new...).

@jkuester jkuester added Dependencies Update the project's dependencies/libraries Type: Technical issue Improve something that users won't notice labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Update the project's dependencies/libraries Type: Technical issue Improve something that users won't notice
Projects
None yet
Development

No branches or pull requests

1 participant