From b38f2a9f1849018d61500a560fb3c26ebf31b2df Mon Sep 17 00:00:00 2001 From: Rick Harrison Date: Tue, 19 Jul 2016 17:32:06 -0700 Subject: [PATCH] Adds ESLint. --- .eslintrc | 7 +++++++ index.js | 14 ++++++++++---- package.json | 6 ++++++ 3 files changed, 23 insertions(+), 4 deletions(-) create mode 100644 .eslintrc diff --git a/.eslintrc b/.eslintrc new file mode 100644 index 0000000..ed6b4df --- /dev/null +++ b/.eslintrc @@ -0,0 +1,7 @@ +{ + "extends": "@meadow", + + "parserOptions": { + "sourceType": "script" + }, +} diff --git a/index.js b/index.js index 0f43610..529eeb6 100644 --- a/index.js +++ b/index.js @@ -8,10 +8,12 @@ const DEFAULT_OPTS = { accessKeyId: '', secretAccessKey: '', queue: '' -} +}; const Client = function Client (opts = DEFAULT_OPTS) { - if (!(this instanceof Client)) return new Client(opts); + if (!(this instanceof Client)) { + return new Client(opts); + } const { region, accessKeyId, secretAccessKey, queue } = opts; @@ -44,7 +46,7 @@ Client.prototype.sendMessage = function sendMessage (payload) { return reject(err); } - resolve(data); + return resolve(data); }); }); }; @@ -72,6 +74,10 @@ Client.prototype.pollQueue = function pollQueue (opts = {}, handler) { const self = this; this.sqs.receiveMessage(this.receiveOptions, (err, data) => { + if (err) { + // Not needed + } + const promises = []; if (data && data.Messages) { @@ -109,7 +115,7 @@ Client.prototype.handleMessage = function handleMessage (message, handler) { return messagePromise.then(() => { return this.deleteMessage(message.ReceiptHandle); - }) + }); }; /* diff --git a/package.json b/package.json index 09e4590..24480c3 100644 --- a/package.json +++ b/package.json @@ -4,6 +4,7 @@ "description": "Client for Amazon SQS with built-in long polling.", "main": "index.js", "scripts": { + "lint": "eslint ./ --ext .js", "test": "echo \"Error: no test specified\" && exit 1" }, "repository": { @@ -29,5 +30,10 @@ "dependencies": { "aws-sdk": "^2.4.7", "lodash.assign": "^4.0.9" + }, + "devDependencies": { + "@meadow/eslint-config": "^2.0.0", + "babel-eslint": "^6.1.2", + "eslint": "^3.1.1" } }