Lots of improvements. #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we merge pull request |
tj-commits
changed the title
|
It's vital to keep such a critical piece of Internet infrastructure free of heavy dependencies, so I'm not keen on this approach. Worth considering if you can find a way to do this without requiring external modules. |
|
@mde Hmm, okay. But besides that I also provided some more fixes. Should those be applied? Like, updating the README.md to be more accurate, and adding CLI to https://github.com/mde/false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THESE FIXES ARE CRUCIAL AND SOLVE MANY PROBLEMS
resolves #5 i made the module.exports immutable using @Ginden 's solution
resolves #19 i made true not hardcode using @tfrijsewijk's solution
also makes bin/cli.js actually log "true".
also there was a ./true in the require function in readme.md which is a hint from testing periods. This would not work if someone installed, therefore this is a crucial fix
i have also done the same things but for false on the https://github.com/mde/false mde/false library