bootutil/crypto: Escalate sha errors when hashing images

kkrentz · kkrentz · commit 7298a738c0e4 · 2025-12-09T23:08:33.000+01:00
Thus far, hashing errors were silently ignored when hashing images.

Signed-off-by: kkrentz &lt;konrad.krentz@gmail.com&gt;
diff --git a/boot/bootutil/src/bootutil_img_hash.c b/boot/bootutil/src/bootutil_img_hash.c
@@ -190,9 +190,9 @@ bootutil_img_hash(struct boot_loader_state *state,
     }
 #endif /* MCUBOOT_RAM_LOAD */
 #endif /* MCUBOOT_HASH_STORAGE_DIRECTLY */
-    bootutil_sha_finish(&sha_ctx, hash_result);
+    rc = bootutil_sha_finish(&sha_ctx, hash_result);
     bootutil_sha_drop(&sha_ctx);
 
-    return 0;
+    return rc;
 }
 #endif /* !MCUBOOT_SIGN_PURE */

Original file line number	Diff line number	Diff line change
`@@ -190,9 +190,9 @@ bootutil_img_hash(struct boot_loader_state *state,`
`190`	`190`	`}`
`191`	`191`	`#endif /* MCUBOOT_RAM_LOAD */`
`192`	`192`	`#endif /* MCUBOOT_HASH_STORAGE_DIRECTLY */`
`193`		`- bootutil_sha_finish(&sha_ctx, hash_result);`
	`193`	`+ rc = bootutil_sha_finish(&sha_ctx, hash_result);`
`194`	`194`	`bootutil_sha_drop(&sha_ctx);`
`195`	`195`
`196`		`- return 0;`
	`196`	`+ return rc;`
`197`	`197`	`}`
`198`	`198`	`#endif /* !MCUBOOT_SIGN_PURE */`