Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCS Bugs and improvements #107

Closed
24 of 28 tasks
mcnuttandrew opened this issue Sep 13, 2024 · 4 comments
Closed
24 of 28 tasks

MCS Bugs and improvements #107

mcnuttandrew opened this issue Sep 13, 2024 · 4 comments

Comments

@mcnuttandrew
Copy link
Owner

mcnuttandrew commented Sep 13, 2024

Browse/Manage

  • After clicking on a palette, the palette updates and the tab switches to samples. Leave the tab on the view of the palettes
  • In the manage pane, make the windows tight on the palettes, as in Browse

Editing and color spaces

Possible additional color spaces

  • add xyz space #119
  • xyY While not supported natively in the Color package, the conversion between this and XYZ is trivial: x = X/(X+Y+Z), y = Y/(X+Y+Z); Plot xy on the plane, Y on the lightness scale. This will show the colors on the CIE Chromaticity diagram.

Comparison

  • The dotted line connections are useful if the colors are in the same order and have only changed slightly, but confusing if the palette order has changed (for example, Tableau 10 Classic and Tableau 10). Since small changes are easy to see with just the rings vs disks, I'd leave the lines out for now.
  • To get a palette to compare, it has to be in the Manage set. From the Change Compared Palette dropdown, I'd add a "browse for more palettes" affordance that switched you to the Browse pane.

Eval

  • When you ask for a fix and it displays the before and after palette, the vertical lines seem to connect the colors that didn't change. I would expect to have them on the colors that did change. Ideally, they'd be arrows pointing from/to.
  • These palettes are labeled Use and Reject. I think it would be useful if they included what algorithm was used. For example, Use(ColorBuddy), Reject(LLM)
  • In Gamut should be a Usability Check, not a Design Check.
  • Settings raises a long list of lints, which really needs a scroll bar or some other way of managing the list on a smaller screen. Also, it would be more conventional to make this a list of Selected lints rather than a List of Ignored lints.
  • the New lint text box doesn't seem to do anything. I tried several types of requests, got nothing back.
  • Being able to copy and modify an existing lint seems very powerful, but I see no way to do that. AM: click lint info / click customize / click clone
  • I would like a way to test all colors for text legibility, no matter what their tags are. Maybe this is just a new lint?
  • I would like to improve the appearance of the red X's on the colors. Ideally, we'd have some tasteful icons, one per major category (Usability, Accessibility, Design, Custom) that were legible on all colors.
  • I'd like to see more metrics in the lint descriptions and errors. For example, what contrast do we need for text legibility, and what is the contrast for those colors that failed?
  • tagged lints not updating smoothly #120

Simulations

  • As noted before, the simulated L* values are noticably different than the original, which is surprising. This is true even for grayscale, so I really wonder if there's some bug in the L* plotting pipeline, rather than in the algorithms.
@mcnuttandrew
Copy link
Owner Author

Re the JzAzBz space: yes those are the correct values. I couldn't reproduce there not being a background. It's got a pretty weird shape which might be making it appear to have no colors?

@mcnuttandrew
Copy link
Owner Author

I'd like to see more metrics in the lint descriptions and errors. For example, what contrast do we need for text legibility, and what is the contrast for those colors that failed?

The general solution to this is a much bigger story involving some actual research, but for simplicity this could just be added to the error message (which would address the first half)

@mcnuttandrew
Copy link
Owner Author

note: colors not updating with tag changes: its a caching issue

@mcnuttandrew
Copy link
Owner Author

closing this thread in favor of a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant