Skip to content

Commit e6973f4

Browse files
committed
Update GitHub refs, minor grammar error in README
It seems the README won't expand refs like bazel-contrib#1482. This updates such refs to use the repo prefix, e.g., bazel-contrib#1482.
1 parent 9041747 commit e6973f4

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

README.md

+15-15
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ the following dependency versions, make sure to `load()` them before calling
4747

4848
As of version 7.0.0, __`rules_scala` no longer requires the
4949
`io_bazel_rules_scala` repository name__ unless your `BUILD` files or those of
50-
your dependencies require it (#1696). In that case, the old name will still work
51-
when using `http_archive`.
50+
your dependencies require it (bazelbuild/rules_scala#1696). In that case, the
51+
old name will still work when using `http_archive`.
5252

5353
```py
5454
# WORKSPACE
@@ -134,7 +134,7 @@ load(
134134

135135
# Defines a default toolchain repo for the configured Scala version that
136136
# loads Maven deps like the Scala compiler and standard libs. On production
137-
# projects, you may consider defining a custom toolchains to use your project's
137+
# projects, you may consider defining a custom toolchain to use your project's
138138
# required dependencies instead.
139139
#
140140
# Optional builtin rules_scala toolchains may be configured by setting
@@ -249,7 +249,7 @@ Please check [cross-compilation.md](docs/cross-compilation.md) for more details
249249
Bazel compatibility is tied directly to the versions of `protobuf` required by
250250
Bazel and `rules_java`, and their compatibility with [scalabp/ScalaPB](
251251
https://github.com/scalapb/ScalaPB) Maven artifacts. For extensive analysis,
252-
see #1647.
252+
see bazelbuild/rules_scala#1647.
253253

254254
The Bazel versions and dependency versions in the table below represent the
255255
maximum available at the time of writing.
@@ -262,9 +262,9 @@ maximum available at the time of writing.
262262

263263
[ci-config]: ./.bazelci/presubmit.yml
264264

265-
| Bazel/Dependency | `rules_scala` 7.x | `rules_scala` 8.x<br/>(Coming soon! See #1482 and #1652.) |
265+
| Bazel/Dependency | `rules_scala` 7.x | `rules_scala` 8.x<br/>(Coming soon! See bazelbuild/rules_scala#1482 and bazelbuild/rules_scala#1652.) |
266266
| :-: | :-: | :-: |
267-
| Bazel versions using Bzlmod<br/>(Coming soon! See #1482.) | 6.5.0, 7.5.0 | 7.5.0, 8.x |
267+
| Bazel versions using Bzlmod<br/>(Coming soon! See bazelbuild/rules_scala#1482.) | 6.5.0, 7.5.0 | 7.5.0, 8.x |
268268
| Bazel versions using `WORKSPACE` | 6.5.0, 7.5.0 | 6.5.0, 7.5.0, 8.x<br/>(see the [notes on 6.5.0 compatibility](#6.5.0)) |
269269
| `protobuf` | v21.7<br/>(can support up to v25.5) | v29.3 |
270270
| `abseil-cpp` | 20220623.1 | 20250127.0 |
@@ -538,7 +538,7 @@ register a specific toolchain to resolve first).
538538
[reg_tool]: https://bazel.build/rules/lib/globals/module#register_toolchains
539539

540540
The `MODULE.bazel` files in this repository will also provide many examples
541-
(when they land per #1482).
541+
(when they land per bazelbuild/rules_scala#1482).
542542

543543
### Embedded resource paths no longer begin with `external/<repo_name>`
544544

@@ -560,10 +560,10 @@ depend](https://bazel.build/external/module#repository_names_and_strict_deps).
560560

561561
### Update `@bazel_tools//tools/jdk` targets to `@rules_java//toolchains` targets
562562

563-
Per #1660, `rules_java` 7.10.0 and later precipitate the need to replace
564-
`@bazel_tools//tools/jdk` targets with corresponding `@rules_java//toolchains`
565-
targets. Fix any targets broken by this `rules_java` upgrade by doing a global
566-
search and replace.
563+
Per bazelbuild/rules_scala#1660, `rules_java` 7.10.0 and later precipitate the
564+
need to replace `@bazel_tools//tools/jdk` targets with corresponding
565+
`@rules_java//toolchains` targets. Fix any targets broken by this `rules_java`
566+
upgrade by doing a global search and replace.
567567

568568
However, `@bazel_tools//tools/jdk:toolchain_type` dependencies must remain for
569569
now, as there's not yet a corresponding [`toolchain_type()`](
@@ -580,10 +580,10 @@ breaking changes when upgrading from `rules_scala` 7.x.
580580
### Replace some `$(location)` calls with `$(rootpath)` for Bazel 8
581581

582582
This isn't actually a `rules_scala` breakage, but a Bazel 8 breakage encountered
583-
while preparing `rules_scala` for Bazel 8 in #1652.
584-
bazelbuild/rules_scala@7b98e3a and bazelbuild/bazel#25198 describe how the
585-
semantics of some instances of `$(location)` changed, and how changing these
586-
particular instances to `$(rootpath)` fixed them.
583+
while preparing `rules_scala` for Bazel 8 in bazelbuild/rules_scala#1652.
584+
bazelbuild/bazel#25198 describes how the semantics of some instances of
585+
`$(location)` changed, and how changing these particular instances to
586+
`$(rootpath)` fixed them.
587587

588588
The good news is that replacing such instances `$(location)` with `$(rootpath)`
589589
is backwards compatible to Bazel 6.5.0 and 7.5.0. Updating them now will ensure

0 commit comments

Comments
 (0)