Skip to content

Commit c7f4ebd

Browse files
committed
Minor typographical tweaks in README.md
Removed `code formatted strings` inside of links. (Force of habit.) Updated Bzlmod examples to match the formatting produced by `bazel mod tidy`. Bumped the `rules_java` version in "Compatible Bazel versions" to 8.11.0.
1 parent 7387609 commit c7f4ebd

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

README.md

+6-11
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ load(
198198

199199
`rules_scala` now supports the
200200
[`--incompatible_enable_proto_toolchain_resolution`][] flag when using
201-
[`protobuf` v29 or later](#why-proto-v29). When using this flag with the
201+
[protobuf v29 or later](#why-proto-v29). When using this flag with the
202202
`MODULE.bazel` or `WORKSPACE` configurations below, `rules_scala` will use a
203203
precompiled protocol compiler binary by default.
204204

@@ -248,7 +248,6 @@ scala_deps = use_extension(
248248
"@rules_scala//scala/extensions:deps.bzl",
249249
"scala_deps",
250250
)
251-
252251
scala_deps.toolchains(
253252
protoc_platforms = ["linux-x86_64"],
254253
)
@@ -305,12 +304,11 @@ bazel_dep(
305304
version = "30.1",
306305
repo_name = "com_google_protobuf",
307306
)
308-
309307
single_version_override(
310308
module_name = "protobuf",
311-
version = "30.1",
312-
patches = ["//:protobuf.patch"],
313309
patch_strip = 1,
310+
patches = ["//:protobuf.patch"],
311+
version = "30.1",
314312
)
315313
```
316314

@@ -483,7 +481,7 @@ maximum available at the time of writing.
483481
| Bazel versions using `WORKSPACE` | 6.5.0, 7.5.0, 8.x<br/>(see the [notes on 6.5.0 compatibility](#6.5.0)) |
484482
| `protobuf` | v30.1 |
485483
| `abseil-cpp` | 20250127.0 |
486-
| `rules_java` | 8.10.0 |
484+
| `rules_java` | 8.11.0 |
487485
| `ScalaPB` | 1.0.0-alpha.1 |
488486

489487
## Usage with [bazel-deps](https://github.com/johnynek/bazel-deps)
@@ -727,14 +725,12 @@ scala_config = use_extension(
727725
"@rules_scala//scala/extensions:config.bzl",
728726
"scala_config",
729727
)
730-
731728
scala_config.settings(scala_version = "2.13.16")
732729

733730
scala_deps = use_extension(
734731
"@rules_scala//scala/extensions:deps.bzl",
735732
"scala_deps",
736733
)
737-
738734
scala_deps.toolchains(
739735
scalafmt = True,
740736
scalatest = True,
@@ -789,7 +785,6 @@ scala_config = use_extension(
789785
"@rules_scala//scala/extensions:config.bzl",
790786
"scala_config",
791787
)
792-
793788
use_repo(scala_config, io_bazel_rules_scala_config = "rules_scala_config")
794789
```
795790

@@ -908,7 +903,7 @@ Under Bzlmod, repos are only visible to the module extension that creates them,
908903
unless the `MODULE.bazel` file brings them into scope with
909904
[`use_repo()`](https://bazel.build/rules/lib/globals/module#use_repo). This can
910905
lead to errors like those from the following example, which [originally called
911-
`setup_scala_toolchain()` under Bzlmod](
906+
'setup_scala_toolchain()' under Bzlmod](
912907
https://github.com/michalbogacz/scala-bazel-monorepo/blob/17f0890a4345529e09b9ce83bcb2e3d15687c522/BUILD.bazel):
913908

914909
```py
@@ -1074,7 +1069,7 @@ https://github.com/scalapb/ScalaPB/releases/tag/v1.0.0-alpha.1), we had to
10741069
remove the Scala 2.11 test cases.
10751070

10761071
Building `scala_proto` for Scala 2.11 requires [building with Bazel 6.5.0
1077-
under `WORKSPACE`](#6.5.0), with the maximum dependency versions specified in
1072+
under WORKSPACE](#6.5.0), with the maximum dependency versions specified in
10781073
that section. While this may continue to work for some time, it is not
10791074
officially supported.
10801075

0 commit comments

Comments
 (0)