Expose scala_protoc_toolchains as a repo rule

Enables greater consistency between Bzlmod and `WORKSPACE` while
reducing implementation complexity. There's now only the repo rule, not
a wrapper macro and an extension.

The user was always going to need to register this toolchain in the main
module, even under Bzlmod. Exposing the repo rule puts the `protoc`
toolchain's name under the user's control, instead of making it part of
the `rules_scala` public API.

Uses `rules_proto` as an intermediary to `protobuf` APIs for detecting
`--incompatible_enable_proto_toolchain_resolution`. This enables
users to use older versions of `protobuf` and `rules_proto` without
breaking `rules_scala`. Also updated the `scala_proto_toolchain`
implementation to access the precompiled `protoc` via mechanisms moved
to `protoc/private/protoc_toolchain.bzl`.

Author: mbland

README.md

@@ -75,9 +75,10 @@ load("@platforms//host:extension.bzl", "host_platform_repo")
 host_platform_repo(name = "host_platform")
 
 # This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`. Requires calling
-# `scala_protoc_toolchains()` as seen below.
-register_toolchains("@rules_scala//protoc:all")
+# `--incompatible_enable_proto_toolchain_resolution`. Requires invoking the
+# `scala_protoc_toolchains` repo rule. Register this toolchain before any
+# others. See the "Using a precompiled protocol compiler" section below.
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -125,12 +126,13 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Include this after loading `platforms` and `com_google_protobuf` to enable the
-# `//protoc` precompiled protocol compiler toolchains. See the "Using a
-# precompiled protocol compiler" section below.
+# Include this after loading `platforms`, `com_google_protobuf`, and
+# `rules_proto` to enable the `//protoc` precompiled protocol compiler
+# toolchains. See the "Using a precompiled protocol compiler" section below.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+# This name can be anything, but we recommend `rules_scala_protoc_toolchains`.
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 
@@ -224,41 +226,57 @@ To set the flag in your `.bazelrc` file:
 common --incompatible_enable_proto_toolchain_resolution
 ```
 
-In both `MODULE.bazel` and `WORKSPACE`, add the following statement _before_ any
-other toolchain registrations. It's safe to include even when not using
-`--incompatible_enable_proto_toolchain_resolution`.
+In both `MODULE.bazel` and `WORKSPACE`, add the following `register_toolchains`
+statement _before_ any other toolchain registrations. It's safe to include even
+when not using `--incompatible_enable_proto_toolchain_resolution`.
+
+The repository name of the target is determined by the
+`scala_protoc_toolchains()` repo rule invocation, as illustrated below. It is OK
+to call `register_toolchains` before the repo rule.
 
 ```py
-# MODULE.bazel or WORKSPACE
-register_toolchains("@rules_scala//protoc:all")
+# MODULE.bazel
+register_toolchains(
+    "@rules_scala_protoc_toolchains//...:all",
+    dev_dependency = True,
+)
+
+# WORKSPACE
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 ```
 
-#### Using `scala_protoc` in `MODULE.bazel`
+#### Invoking the `scala_protoc_toolchains()` repo rule
 
-The `scala_protoc` extension instantiates the protocol compiler toolchain
-binaries under Bzlmod:
+The `scala_protoc_toolchains` repo rule instantiates the protocol compiler
+toolchain. The repo name can be anything, but we recommend `rules_scala_protoc_toolchains`.
+
+Under Bzlmod, this looks like:
 
 ```py
 # MODULE.bazel
 
-scala_protoc = use_extension(
-    "@rules_scala//scala/extensions:protoc.bzl",
-    "scala_protoc",
+scala_protoc_toolchains = use_repo_rule(
+    "@rules_scala//protoc:toolchains.bzl",
+    "scala_protoc_toolchains",
 )
-```
 
-#### Calling `scala_protoc_toolchains()` in `WORKSPACE`
+# This name can be anything, but we recommend `rules_scala_protoc_toolchains`.
+scala_protoc_toolchains(
+    name = "rules_scala_protoc_toolchains",
+    dev_dependency = True,
+)
+```
 
-The `scala_protoc_toolchains` macro instantiates the protocol compiler toolchain
-binaries under `WORKSPACE`:
+Under `WORKSPACE`, this looks like:
 
 ```py
 # WORKSPACE
 
-# Include this after loading `platforms` and `com_google_protobuf`.
+# Include this after loading `platforms`, `com_google_protobuf`, and
+# `rules_proto`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 ```
 
 #### Specifying additional `protoc` platforms
@@ -280,8 +298,10 @@ the remote execution platform is Linux running on an x86 processor.
 ```py
 # MODULE.bazel
 
-scala_protoc.toolchains(
+scala_protoc_toolchains(
+    name = "rules_scala_protoc_toolchains",
     platforms = ["linux-x86_64"],
+    dev_dependency = True,
 )
 ```
 
@@ -291,6 +311,7 @@ In `WORKSPACE` you would include:
 # WORKSPACE
 
 scala_protoc_toolchains(
+    name = "rules_scala_protoc_toolchains",
     platforms = ["linux-x86_64"],
 )
 ```
@@ -308,7 +329,7 @@ transitive dependency on `@com_google_protobuf//:protoc` remains, causing
 If and when `protobuf` merges that pull request, or applies an equivalent fix,
 this patch will no longer be necessary.
 
-#### Bzlmod setup
+#### `protobuf` patch setup under Bzlmod
 
 Applying the `protobuf` patch requires using [`single_version_override`][],
 which also requires that the patch be a regular file in your own repo. In other
@@ -339,7 +360,7 @@ single_version_override(
 )
 ```
 
-#### `WORKSPACE` setup
+#### `protobuf` patch setup under `WORKSPACE`
 
 [`scala/deps.bzl`](./scala/deps.bzl) already applies the `protobuf` patch by
 default. If you need to apply it yourself, you can also copy it to your repo as

WORKSPACE

@@ -14,8 +14,10 @@ load("@platforms//host:extension.bzl", "host_platform_repo")
 host_platform_repo(name = "host_platform")
 
 # This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("//protoc:all")
+# `--incompatible_enable_proto_toolchain_resolution`. Requires invoking the
+# `scala_protoc_toolchains` repo rule. Register this toolchain before any
+# others.
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -56,10 +58,13 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
-load("//protoc:toolchains.bzl", "scala_protoc_toolchains")
+# Include this after loading `platforms`, `com_google_protobuf`, and
+# `rules_proto` to enable the `//protoc` precompiled protocol compiler
+# toolchains.
+load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+# This name can be anything, but we recommend `rules_scala_protoc_toolchains`.
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("//:scala_config.bzl", "scala_config")
 

dt_patches/test_dt_patches/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 

dt_patches/test_dt_patches_user_srcjar/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 

examples/crossbuild/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 

examples/overridden_artifacts/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 

examples/scala3/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 

examples/semanticdb/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")
 

examples/testing/multi_frameworks_toolchain/WORKSPACE

@@ -11,17 +11,11 @@ load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
-# Only include the next two statements if using
-# `--incompatible_enable_proto_toolchain_resolution`.
 load("@platforms//host:extension.bzl", "host_platform_repo")
 
-# Instantiates the `@host_platform` repo to work around:
-# - https://github.com/bazelbuild/bazel/issues/22558
 host_platform_repo(name = "host_platform")
 
-# This is optional, but still safe to include even when not using
-# `--incompatible_enable_proto_toolchain_resolution`.
-register_toolchains("@rules_scala//protoc:all")
+register_toolchains("@rules_scala_protoc_toolchains//...:all")
 
 load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
 
@@ -62,10 +56,9 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-# Must come after loading `platforms` and `com_google_protobuf`.
 load("@rules_scala//protoc:toolchains.bzl", "scala_protoc_toolchains")
 
-scala_protoc_toolchains()
+scala_protoc_toolchains(name = "rules_scala_protoc_toolchains")
 
 load("@rules_scala//:scala_config.bzl", "scala_config")