Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated oas and oas_file fields from Service #101

Open
1 task done
stevenbal opened this issue Nov 12, 2024 · 1 comment · May be fixed by #108
Open
1 task done

Remove deprecated oas and oas_file fields from Service #101

stevenbal opened this issue Nov 12, 2024 · 1 comment · May be fixed by #108
Assignees
@stevenbal

Comments

@stevenbal
Copy link
Contributor

stevenbal commented Nov 12, 2024 •
edited
Loading

Since ape-pie APIClient doesn't use these fields anymore, they're unnecessarily cluttering the admin UI

TODO:

  • check if these are no longer used in Open Zaak/Open Notificaties/etc.
@stevenbal stevenbal self-assigned this Nov 12, 2024
@stevenbal stevenbal moved this from Triage to Todo in Data en API fundament Nov 12, 2024
@sergei-maertens
Copy link
Member

⚠️ This requires/implies dropping support for zds-client:

zgw-consumers/pyproject.toml

Line 53 in ce82492

zds-client = [

(and my opinion on that is: let's do it!)

@stevenbal stevenbal moved this from Todo to In Progress in Data en API fundament Mar 4, 2025
stevenbal added a commit that referenced this issue Mar 4, 2025
@stevenbal
🗑️ [#101] Remove code that was scheduled for deprecation in 1.0
f4911aa 
which includes any OAS related code and zds-client related code
@stevenbal stevenbal linked a pull request Mar 4, 2025 that will close this issue
Open
stevenbal added a commit that referenced this issue Mar 4, 2025
@stevenbal
📝 [#101] Remove deprecated classes/functions from docs
95a25d4
stevenbal added a commit that referenced this issue Mar 7, 2025
@stevenbal
🗑️ [#101] Remove code that was scheduled for deprecation in 1.0
243d907 
which includes any OAS related code and zds-client related code
stevenbal added a commit that referenced this issue Mar 7, 2025
@stevenbal
➖ [#101] Remove zds-client dependency
1860e15
stevenbal added a commit that referenced this issue Mar 7, 2025
@stevenbal
📝 [#101] Update docs after removal of deprecated code
2465aaf 
remove deprecated classes/functions/settings from docs
@stevenbal stevenbal moved this from In Progress to Implemented in Data en API fundament Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
None yet
Projects
Data en API fundament
Status: Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🗑️ [#101] Remove code that was scheduled for deprecation in 1.0 maykinmedia/zgw-consumers
2 participants
@sergei-maertens @stevenbal