Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs containing multiple dots before the extension get truncated when building URLs #46

Open
gpoole opened this issue Nov 28, 2022 · 1 comment · May be fixed by #45
Open

URLs containing multiple dots before the extension get truncated when building URLs #46

gpoole opened this issue Nov 28, 2022 · 1 comment · May be fixed by #45

Comments

@gpoole
Copy link

gpoole commented Nov 28, 2022 •
edited
Loading

Public IDs containing multiple dots before the extension are getting truncated. For example, in 0.2.4 https://res.cloudinary.com/xyz/image/upload/v111111111/Folder/Name.With.Multiple.Dots.png is extracted as Folder/Name instead of Folder/Name.With.Multiple.Dots.

It looks like it's an issue with the extractPublicId regex assuming everything after the first . is the extension.

Related to #22 I think
@gpoole gpoole linked a pull request Nov 28, 2022 that will close this issue
Open
@Noushad-web
Copy link

I'm facing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix truncating urls for paths with multiple dots (#46) gpoole/cloudinary-api
2 participants
@gpoole @Noushad-web